Commit 21a2e7c
Fix Newton GL Pause Rendering desync and document Rerun Play/Pause limitation (#7506)
## Summary
- Fixed the Newton GL visualizer's "Pause Rendering" button not
reflecting the paused state after pressing `Space`. Both controls now
read/write the same underlying `_paused` flag, so the button label and
`is_rendering_paused()` stay in sync regardless of whether rendering was
paused via the button or the keyboard shortcut. Also clarified the
on-screen control hint from "Space - Pause/Resume" to "Space -
Pause/Resume Rendering".
- Documented that the Rerun visualizer's native Play/Pause timeline
controls do not work while visualizing a live simulation/training run
(they only scrub already-logged `.rrd` recordings). Isaac Lab's own
**Pause Rendering** / **Reset Episode** ImGui controls should be used
instead for the live view.
## Release backport
- [x] <!-- backport-active-release --> Backport this pull request to the
active release branch after it merges into `develop`
## Test plan
- [x] `uv run isaaclab -f` (ruff, ruff format, rst checks, changelog
fragment check) — all passed
- [x] `uv run python tools/changelog/cli.py check develop` — passed
- [x] `uv run --extra test python -m pytest
source/isaaclab_visualizers/test/test_newton_adapter.py -v` — 51/51
passed, including new regression test
`test_newton_gl_viewer_rendering_pause_state_stays_in_sync_with_space_key`
(verified it fails without the fix, passes with it)
- [x] Manually verified live in the Newton GL visualizer window: Space
now flips the Pause/Resume Rendering button label immediately, matching
a direct click
(cherry picked from commit c96b25f)1 parent 7cba60f commit 21a2e7c
4 files changed
Lines changed: 78 additions & 7 deletions
File tree
- docs/source/overview/core-concepts
- source/isaaclab_visualizers
- changelog.d
- isaaclab_visualizers/newton
- test
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
758 | 758 | | |
759 | 759 | | |
760 | 760 | | |
| 761 | + | |
| 762 | + | |
| 763 | + | |
| 764 | + | |
| 765 | + | |
| 766 | + | |
| 767 | + | |
| 768 | + | |
| 769 | + | |
761 | 770 | | |
762 | 771 | | |
763 | 772 | | |
| |||
Lines changed: 9 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
Lines changed: 12 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
467 | 467 | | |
468 | 468 | | |
469 | 469 | | |
470 | | - | |
| 470 | + | |
471 | 471 | | |
472 | 472 | | |
473 | 473 | | |
| |||
487 | 487 | | |
488 | 488 | | |
489 | 489 | | |
| 490 | + | |
| 491 | + | |
| 492 | + | |
490 | 493 | | |
491 | | - | |
| 494 | + | |
492 | 495 | | |
493 | | - | |
494 | | - | |
| 496 | + | |
495 | 497 | | |
496 | 498 | | |
497 | 499 | | |
| |||
733 | 735 | | |
734 | 736 | | |
735 | 737 | | |
736 | | - | |
737 | 738 | | |
738 | 739 | | |
739 | 740 | | |
| |||
763 | 764 | | |
764 | 765 | | |
765 | 766 | | |
766 | | - | |
767 | | - | |
| 767 | + | |
| 768 | + | |
| 769 | + | |
| 770 | + | |
| 771 | + | |
| 772 | + | |
768 | 773 | | |
769 | 774 | | |
770 | 775 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
292 | 292 | | |
293 | 293 | | |
294 | 294 | | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
295 | 343 | | |
296 | 344 | | |
297 | 345 | | |
| |||
0 commit comments