Skip to content

Commit 3d14980

Browse files
committed
Default random agent to Newton visualizer
1 parent 0fa4d34 commit 3d14980

3 files changed

Lines changed: 8 additions & 9 deletions

File tree

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
Changed
22
^^^^^^^
33

4-
* Changed the zero agent to use the Newton GL visualizer by default. Pass ``--viz kit`` to keep using the Kit
5-
visualizer.
4+
* Changed the zero and random agents to use the Newton GL visualizer by default. Pass ``--viz kit`` to keep using
5+
the Kit visualizer.

source/isaaclab_rl/isaaclab_rl/entrypoints/simple_agents.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -245,8 +245,8 @@ def _parse_args(argv: list[str] | None, policy: PolicyName) -> argparse.Namespac
245245
)
246246
# append AppLauncher cli args
247247
add_launcher_args(parser)
248-
# Keep the zero agent on the kitless default path while preserving the random-agent behavior.
249-
parser.set_defaults(visualizer=["newton_gl"] if policy == "zero" else ["kit"])
248+
# Keep checkpoint-free agents on the kitless default path.
249+
parser.set_defaults(visualizer=["newton_gl"])
250250
args_cli, hydra_args = setup_preset_cli(parser, argv)
251251
sys.argv = [sys.argv[0]] + hydra_args
252252
return args_cli

source/isaaclab_rl/test/test_entrypoints.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -184,18 +184,17 @@ def test_zero_agent_supports_direct_multi_agent_action_spaces() -> None:
184184
assert torch.equal(actions["object"], torch.zeros(3, 1, dtype=torch.int64))
185185

186186

187-
@pytest.mark.parametrize(("policy", "expected_visualizer"), [("zero", ["newton_gl"]), ("random", ["kit"])])
188-
def test_simple_agent_default_visualizer_depends_on_policy(
187+
@pytest.mark.parametrize("policy", ["zero", "random"])
188+
def test_simple_agents_default_to_newton_visualizer(
189189
policy: _simple_agents.PolicyName,
190-
expected_visualizer: list[str],
191190
monkeypatch: pytest.MonkeyPatch,
192191
) -> None:
193-
"""The zero agent defaults to Newton visualization without changing the random agent."""
192+
"""Checkpoint-free agents default to Newton visualization."""
194193
monkeypatch.setattr(sys, "argv", ["pytest"])
195194

196195
args = _simple_agents._parse_args([], policy)
197196

198-
assert args.visualizer == expected_visualizer
197+
assert args.visualizer == ["newton_gl"]
199198

200199

201200
def test_zero_agent_rejects_invalid_config_before_launch(monkeypatch: pytest.MonkeyPatch) -> None:

0 commit comments

Comments
 (0)