Commit 5d254cc
authored
Fix Factory collision prim resolution (#7093)
# Description
Fixes `IsaacContrib-Factory-Franka` startup after segment-safe prim-path
expressions were introduced in #6841.
The Factory collision analyzer assumed cloned environment expressions
contained `.*`. It rewrote that spelling to `0` to find a source prim,
then rebuilt an `env_.*` expression. The current `{ENV_REGEX_NS}`
expansion is `/World/envs/env_[^/]+`, so the rewrite no longer produced
a concrete USD path and startup failed with:
```text
ValueError: Prim at path /World/envs/env_[^/]+/Robot is not valid.
```
This change resolves each collision body through
`resolve_matching_prims_from_source`, the clone-plan-owned resolver. Its
returned destination path expression is passed directly to point-cloud
sampling, removing both wildcard-spelling rewrites and keeping ownership
of clone-path resolution in the cloning subsystem.
No new dependencies or test files are introduced.
## Type of change
- Bug fix (non-breaking change which fixes an issue)
## Screenshots
Not applicable; this is an environment-startup fix.
## Validation
- Reproduced the exact failure on unmodified latest `develop` with the
existing consolidated Factory smoke case.
- Existing `IsaacContrib-Factory-Franka` smoke case: **1 passed in
39.33s**, including two environments and 20 random-action steps.
- Full `uv run isaaclab -f` equivalent repository hook suite: passed.
- `git diff --check upstream/develop...HEAD`: passed.
## Checklist
- [x] I have read and understood the [contribution
guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html)
- [x] I have run the pre-commit checks with `isaaclab -f`
- [x] Documentation changes are not required; the changelog fragment
documents the fix
- [x] My changes generate no new warnings
- [x] The existing consolidated Factory smoke test proves the fix; no
new test file is required
- [x] I have added a changelog fragment under
`source/isaaclab_tasks/changelog.d/`
- [x] My name already exists in `CONTRIBUTORS.md`1 parent a779f1d commit 5d254cc
2 files changed
Lines changed: 10 additions & 5 deletions
File tree
- source/isaaclab_tasks
- changelog.d
- isaaclab_tasks/contrib/nist/utils
Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
Lines changed: 6 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
| 15 | + | |
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| |||
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
55 | | - | |
56 | | - | |
| 55 | + | |
| 56 | + | |
57 | 57 | | |
58 | | - | |
| 58 | + | |
| 59 | + | |
59 | 60 | | |
60 | 61 | | |
61 | 62 | | |
62 | | - | |
| 63 | + | |
63 | 64 | | |
64 | 65 | | |
65 | 66 | | |
| |||
0 commit comments