Commit 6fdadea
authored
Fix SpaceNavigator device detection (#7544)
# Description
This PR adds support for detecting the legacy 3Dconnexion SpaceNavigator
as an `Se3SpaceMouse` input device.
The device reports `SpaceNavigator` as its HID product string. Because
this value was absent from the supported-device check, Isaac Lab raised
a `No device found by SpaceMouse` error even when the device was
connected and accessible.
This change adds `SpaceNavigator` to the existing SpaceMouse
product-string allowlist. No additional dependencies are required.
## Type of change
* Bug fix (non-breaking change which fixes an issue)
## Release backport
* [x] <!-- backport-active-release --> Backport this pull request to the
active release branch after it merges into `develop`
## Screenshots
Not applicable. This change affects HID device detection and does not
alter the user interface.
## Testing
Manually tested on Linux with a 3Dconnexion SpaceNavigator:
* USB ID: `046d:c626`
* HID product string: `SpaceNavigator`
* Before this change, `Se3SpaceMouse` failed to find the connected
device.
* After this change, Isaac Lab successfully detected and opened the
device.
* All pre-commit checks pass with `./isaaclab.sh --format`.
## Checklist
Docker and GPU tests run on demand. Push the commits you want tested,
then comment `run-ci` on the pull request.
* [x] I have read and understood the [[contribution
guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html)](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html)
* [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
* [x] Documentation changes are not required because this change does
not affect the user-facing API
* [x] My changes generate no new warnings
* [ ] I have added tests that prove my fix is effective or that my
feature works
* [x] I have added a changelog fragment under
`source/<pkg>/changelog.d/` for every touched package
* [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there
Signed-off-by: Pranav Shirgur <pranav.shirgur@gmail.com>1 parent 1b182e7 commit 6fdadea
3 files changed
Lines changed: 6 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
168 | 168 | | |
169 | 169 | | |
170 | 170 | | |
| 171 | + | |
171 | 172 | | |
172 | 173 | | |
173 | 174 | | |
| |||
Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
142 | 142 | | |
143 | 143 | | |
144 | 144 | | |
| 145 | + | |
145 | 146 | | |
146 | 147 | | |
147 | 148 | | |
| |||
0 commit comments