Skip to content

Commit 837435f

Browse files
kellyguo115hirgur
andauthored
[Backport release/3.0.0] Fix SpaceNavigator device detection (#7593)
# Description Backports #7544 to `release/3.0.0` after the automated backport workflow skipped the checked selection. This is an exact cherry-pick of merged commit `6fdadeac68be8f01813a4f260b66b9e85d1af9ae`. It adds legacy 3Dconnexion SpaceNavigator detection, the original changelog fragment, and the original contributor entry. No additional dependencies are required. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Release backport - This PR directly targets `release/3.0.0`; no further backport is requested. ## Screenshots Not applicable. This change affects HID device detection and does not alter the user interface. ## Testing - [x] Validated the candidate with `.github/scripts/backport.py validate-candidate --exact_patch` against #7544. - [x] Ran the full pre-commit suite; all hooks passed. - [ ] Hardware validation was not repeated for this exact cherry-pick. The original PR was manually tested on Linux with a SpaceNavigator. ## Checklist - [x] I have read and understood the contribution guidelines - [x] I have run the pre-commit checks - [x] Documentation changes are not required because this change does not affect the public API - [x] My changes generate no new warnings - [x] The original fix and validation are preserved exactly - [x] The original changelog fragment is included - [x] The original contributor entry is included Signed-off-by: Pranav Shirgur <pranav.shirgur@gmail.com> Co-authored-by: Pranav Shirgur <49152866+5hirgur@users.noreply.github.com>
1 parent a22c3fa commit 837435f

3 files changed

Lines changed: 6 additions & 0 deletions

File tree

CONTRIBUTORS.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,7 @@ Guidelines for modifications:
167167
* Peter Verswyvelen
168168
* Philipp Reist
169169
* Piotr Barejko
170+
* Pranav Shirgur
170171
* Pulkit Goyal
171172
* Qian Wan
172173
* Qingyang Jiang
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
Fixed
2+
^^^^^
3+
4+
* Fixed detection of legacy 3Dconnexion SpaceNavigator devices in the SpaceMouse interface.

source/isaaclab/isaaclab/devices/spacemouse/se3_spacemouse.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,7 @@ def _find_device(self):
142142
or device["product_string"] == "SpaceMouse Wireless"
143143
or device["product_string"] == "SpaceNavigator for Notebooks"
144144
or device["product_string"] == "3Dconnexion Universal Receiver"
145+
or device["product_string"] == "SpaceNavigator"
145146
):
146147
# set found flag
147148
found = True

0 commit comments

Comments
 (0)