Skip to content

Commit 8790f3c

Browse files
committed
Drop the Newton 1.5 tendon-adapter shim
Newton 1.6.0rc1 provides the ``mujoco:actuator`` custom-frequency API that the shim backfilled (newton-physics/newton#4017): ``custom_frequency_counts`` and ``custom_frequency_labels`` on the articulation view, and ``custom_frequency_articulation`` on the model. The pin moved to 1.6.0rc1 in #7445, so ``ensure_newton_custom_frequency_api`` already returned both arguments unchanged. The adapter now reads the view and model directly. Removes the shim and its tests; no other module referenced them.
1 parent c749bcb commit 8790f3c

4 files changed

Lines changed: 9 additions & 423 deletions

File tree

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
Removed
2+
^^^^^^^
3+
4+
* Removed the Newton 1.5 compatibility shim for the MuJoCo tendon adapter. Newton 1.6.0rc1
5+
provides the ``mujoco:actuator`` custom-frequency view API (newton-physics/newton#4017)
6+
directly, so the adapter now reads it from the articulation view and model rather than
7+
through a wrapper. No migration is needed: the shim was internal and became a no-op once
8+
the Newton pin moved to 1.6.0rc1.

source/isaaclab_newton/isaaclab_newton/physics/_mjwarp_view_compat.py

Lines changed: 0 additions & 284 deletions
This file was deleted.

source/isaaclab_newton/isaaclab_newton/physics/mjwarp_tendon_control.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,6 @@
3434
from isaaclab_newton.assets import kernels as shared_kernels
3535
from isaaclab_newton.assets.articulation import kernels as articulation_kernels
3636

37-
from ._mjwarp_view_compat import ensure_newton_custom_frequency_api
38-
3937
if TYPE_CHECKING:
4038
from newton import Control, Model
4139
from newton.selection import ArticulationView
@@ -66,9 +64,7 @@ def create(cls, articulation: Articulation, model: Model) -> MjWarpTendonControl
6664
Returns:
6765
The adapter, or None when the articulation's tendons are all passive.
6866
"""
69-
# Single compatibility seam: on Newton 1.6 this returns both unchanged. Everything below,
70-
# and every other module, is written against 1.6 only.
71-
view, model = ensure_newton_custom_frequency_api(articulation.root_view, model)
67+
view = articulation.root_view
7268
mapping = resolve_fixed_tendon_actuator_columns(view, model)
7369
if mapping is None or mapping[0].size == 0:
7470
return None

0 commit comments

Comments
 (0)