Commit 94c24c0
authored
[Workflow] Fix zero agent and random agent to launch newton visualizer by default (#7518)
# Description
The zero and random agents forced the Kit visualizer by default, which
launched the Isaac Sim runtime even when a task resolved to Newton
physics. This change defaults both checkpoint-free agents to the
canonical Newton GL visualizer while preserving explicit --viz
overrides.
A regression test covers both agent defaults. An isaaclab_rl changelog
fragment documents how to retain the Kit visualizer explicitly.
Fixes # N/A
## Type of change
- Bug fix (non-breaking change which fixes an issue)
## Release backport
- [ ] <!-- backport-active-release --> Backport this pull request to the
active release branch after it merges into develop
## Screenshots
N/A — workflow default change.
## Validation
- uv run --frozen python -m pytest
source/isaaclab_rl/test/test_entrypoints.py -q (20 passed, 2 skipped)
- uv run --frozen python tools/changelog/cli.py check develop
- uv run --frozen isaaclab -f
- uv run --frozen isaaclab zero_agent --task Isaac-Cartpole-Direct
--num_envs 1 --max_steps 32 physics=newton_mjwarp
- uv run --frozen isaaclab random_agent --task Isaac-Cartpole-Direct
--num_envs 1 --max_steps 32 physics=newton_mjwarp
Both smoke tests initialized NewtonVisualizer and completed without
launching Isaac Sim/Kit. In the headless validation shell, the Newton
viewer used EGL because DISPLAY was unset.
## Checklist
- [x] I have read and understood the contribution guidelines
- [x] I have run the pre-commit checks
- [x] I have made corresponding changes to the documentation through the
changelog fragment
- [x] My changes generate no new warnings
- [x] I have added tests that prove the fix is effective
- [x] I have added a changelog fragment for every touched package
- [x] My name already exists in CONTRIBUTORS.md1 parent 8ca264b commit 94c24c0
3 files changed
Lines changed: 20 additions & 2 deletions
File tree
- source/isaaclab_rl
- changelog.d
- isaaclab_rl/entrypoints
- test
Lines changed: 5 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
245 | 245 | | |
246 | 246 | | |
247 | 247 | | |
248 | | - | |
249 | | - | |
| 248 | + | |
| 249 | + | |
250 | 250 | | |
251 | 251 | | |
252 | 252 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
224 | 224 | | |
225 | 225 | | |
226 | 226 | | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
227 | 240 | | |
228 | 241 | | |
229 | 242 | | |
| |||
0 commit comments