Commit 9a6c51b
[Backport] Fix kitless multi-GPU tests and ROS link checks (#7558)
# Description
Fixes two release CI failures without backporting #7405.
## Kitless multi-GPU tests
Backports only the release-relevant multi-GPU test fix from #7540.
PR #7466 is present on `release/3.0.0`, so `isaaclab.sh` rejects a
downloaded-Isaac-Sim link alongside the kitless image's active virtual
environment. The test runner currently creates `_isaac_sim ->
/isaac-sim` unconditionally because runtime mounts make `/isaac-sim`
exist even in the kitless image.
This change creates the link only when `/isaac-sim/python.sh` exists.
Kit-based test images retain their existing behavior, while the kitless
multi-GPU smoke test resolves Python from `VIRTUAL_ENV`.
This intentionally excludes #7540's image-invariant/cache changes and
all of #7405, which was not backported to the release branch.
Original PR: #7540
## Documentation link check
The automatic backport's link check failed twice because `www.ros.org`
and `docs.ros.org` return HTTP 403 to the GitHub runner. Both links
remain valid. The link-check workflow already excludes known crawl
blockers, so this adds a single `ros.org` exclusion covering both hosts
without changing the documentation destinations or weakening checks for
other domains.
Failed run:
https://github.com/isaac-sim/IsaacLab/actions/runs/33828925399
## Type of change
- Bug fix (non-breaking change which fixes an issue)
## Release backport
Not applicable: this PR directly targets `release/3.0.0`.
## Validation
- Added a regression test that failed against the unmodified release
branch and passes with the multi-GPU fix.
- `uv run --no-project --with pytest --with pyyaml python -m pytest
docker/test/test_container_profiles.py -q` - 14 passed.
- `bash -n .github/actions/run-tests/run_tests.sh` - passed.
- Parsed `.github/workflows/check-links.yml` with PyYAML and verified
the exclusion matches both failing URLs.
- Applicable file-scoped pre-commit hooks - passed. The branch-wide
changelog hook is not applicable to a release backport because it
compares historical release differences against `develop`.
- The canonical `uv run isaaclab -f` command cannot resolve this
branch's Linux/Windows-only lockfile on macOS; the equivalent
file-scoped hooks were run directly.
## Checklist
- [x] I have read and understood the contribution guidelines.
- [x] I have run the applicable pre-commit checks.
- [x] Documentation destinations remain unchanged.
- [x] My changes generate no new warnings.
- [x] I have added a regression test for the multi-GPU behavior.
- [x] No changelog fragment is required because no source package
changed.
- [x] The contributors already exist in `CONTRIBUTORS.md`.
---------
Co-authored-by: hujc <jichuanh@nvidia.com>1 parent 85ad43c commit 9a6c51b
3 files changed
Lines changed: 21 additions & 2 deletions
File tree
- .github
- actions/run-tests
- workflows
- docker/test
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
320 | 320 | | |
321 | 321 | | |
322 | 322 | | |
323 | | - | |
324 | | - | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
325 | 328 | | |
326 | 329 | | |
327 | 330 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
112 | 112 | | |
113 | 113 | | |
114 | 114 | | |
| 115 | + | |
115 | 116 | | |
116 | 117 | | |
117 | 118 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| 18 | + | |
18 | 19 | | |
19 | 20 | | |
20 | 21 | | |
| |||
288 | 289 | | |
289 | 290 | | |
290 | 291 | | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
291 | 306 | | |
292 | 307 | | |
293 | 308 | | |
| |||
0 commit comments