Commit a6060a9
authored
[FIX] Defer asset imports until Kit startup (#7072)
# Description
Defer the cable and deformable runtime asset imports until after
`launch_simulation()` starts Kit. This prevents the standalone USD
runtime from loading before Kit initializes its bundled USD runtime. The
type annotations are kept via `TYPE_CHECKING` imports, matching the
existing pattern in `scripts/demos/multi_asset.py` and
`scripts/demos/procedural_terrain.py`.
Correct the documented commands for both demos so they install the
extras their default configuration actually needs. The cable demo
defaults to the Kit visualizer, so it needs `--extra isaacsim`. The
deformable tutorial defaults to Kit and always tetrahedralizes its
volume deformables, so it needs `--extra isaacsim --extra
tetrahedralization`; its OvPhysX example stays Kitless but needs
`--extra ovphysx --extra tetrahedralization`. The cable examples that
pass `--visualizer newton` or `--visualizer none` are intentionally left
Kitless.
## Type of change
- Bug fix (non-breaking change which fixes an issue)
- Documentation update
## Screenshots
Not applicable.
## Validation
- `uv run --frozen isaaclab -f`
- Cable demo completed two steps with the Kit visualizer.
- Deformable-object tutorial started Kit and simulated with each of the
three backends, using the documented commands.
- Confirmed each documented extra is genuinely required: with the
tetrahedralization dependencies unavailable, all three backends fail in
`define_deformable_body_properties`.
- Documentation build completed successfully.
## Checklist
- [x] I have read and understood the contribution guidelines
- [x] I have run the pre-commit checks
- [x] I have made corresponding documentation changes
- [x] My changes generate no new warnings
- [x] No source-package changelog fragment is required
- [x] My name already exists in `CONTRIBUTORS.md`1 parent 135cf98 commit a6060a9
5 files changed
Lines changed: 26 additions & 14 deletions
File tree
- docs/source
- overview
- core-concepts/physical-backends/newton
- tutorials/01_assets
- scripts
- demos
- tutorials/01_assets
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
| 33 | + | |
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
113 | 113 | | |
114 | 114 | | |
115 | 115 | | |
116 | | - | |
| 116 | + | |
117 | 117 | | |
118 | 118 | | |
119 | 119 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
29 | | - | |
| 28 | + | |
| 29 | + | |
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
| 33 | + | |
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | | - | |
| 52 | + | |
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
| |||
184 | 184 | | |
185 | 185 | | |
186 | 186 | | |
187 | | - | |
| 187 | + | |
188 | 188 | | |
189 | 189 | | |
190 | 190 | | |
| |||
200 | 200 | | |
201 | 201 | | |
202 | 202 | | |
203 | | - | |
| 203 | + | |
204 | 204 | | |
205 | 205 | | |
206 | 206 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| 26 | + | |
26 | 27 | | |
27 | 28 | | |
28 | 29 | | |
| |||
41 | 42 | | |
42 | 43 | | |
43 | 44 | | |
44 | | - | |
45 | 45 | | |
46 | 46 | | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
47 | 50 | | |
48 | 51 | | |
49 | 52 | | |
| |||
53 | 56 | | |
54 | 57 | | |
55 | 58 | | |
| 59 | + | |
| 60 | + | |
56 | 61 | | |
57 | 62 | | |
58 | 63 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
| 15 | + | |
| 16 | + | |
16 | 17 | | |
17 | 18 | | |
18 | | - | |
| 19 | + | |
| 20 | + | |
19 | 21 | | |
20 | 22 | | |
21 | 23 | | |
22 | 24 | | |
23 | 25 | | |
24 | 26 | | |
| 27 | + | |
25 | 28 | | |
26 | 29 | | |
27 | 30 | | |
| |||
45 | 48 | | |
46 | 49 | | |
47 | 50 | | |
48 | | - | |
49 | 51 | | |
50 | 52 | | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
51 | 56 | | |
52 | 57 | | |
53 | 58 | | |
| 59 | + | |
| 60 | + | |
54 | 61 | | |
55 | 62 | | |
56 | 63 | | |
| |||
0 commit comments