Skip to content

Commit b70958f

Browse files
committed
Clarify contradictory hero-tile-grid CSS comment
The comment claimed both crop classes always produce a 221px tile, but the top-row override added afterward shrinks Viser/Newton RTX to 206px, leaving the two rows' heights undocumented and contradicting each other. Split the comment so it states tiles are only even within each row, and documents the top row's override separately.
1 parent 6c0fada commit b70958f

1 file changed

Lines changed: 8 additions & 6 deletions

File tree

docs/source/concepts/visualization.rst

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,18 +40,20 @@ This page covers:
4040
.viz-label.viz-label-raise { bottom:10px; }
4141
/* Trims pixels off each hero tile on top of whatever object-position crop is already
4242
applied, so the tile itself is shorter rather than just repositioning the existing crop.
43-
Both classes crop to the same final 221px height so the 2x2 tile grid stays even, split
44-
differently per tile: Kit/Rerun/Newton RTX crop 45px off the top and 20px off the bottom;
45-
Viser crops 35px off the top and 30px off the bottom (its object-position framing already
46-
leaves more headroom at the bottom, so it can take a heavier bottom crop). */
43+
Both classes initially crop to the same 221px height, keeping tiles within each row even.
44+
Kit/Rerun/Newton RTX crop 45px off the top and 20px off the bottom; Viser crops 35px off
45+
the top and 30px off the bottom (its object-position framing already leaves more headroom
46+
at the bottom, so it can take a heavier bottom crop). */
4747
.viz-grid-stretch.viz-grid-hero-tiles .viz-hero-wrap { height:276px; }
4848
.viz-grid-stretch.viz-grid-hero-tiles .viz-hero-wrap video { margin-top:-10px; }
4949
.viz-grid-stretch.viz-grid-hero-tiles .viz-hero-wrap.viz-crop-top25 { height:221px; }
5050
.viz-grid-stretch.viz-grid-hero-tiles .viz-hero-wrap.viz-crop-top25 video { margin-top:-45px; }
5151
.viz-grid-stretch.viz-grid-hero-tiles .viz-hero-wrap.viz-crop-mixed { height:221px; }
5252
.viz-grid-stretch.viz-grid-hero-tiles .viz-hero-wrap.viz-crop-mixed video { margin-top:-35px; }
53-
/* Top row (Viser, Newton RTX) additionally crops 15px more off the top than the bottom row,
54-
keeping bottom crop unchanged: height shrinks by 15px and margin-top grows by 15px. */
53+
/* The top row (Viser, Newton RTX) overrides both tiles above to a shorter, still-even 206px:
54+
15px more off the top than the bottom row, with bottom crop unchanged (height shrinks by
55+
15px and margin-top grows by 15px in lockstep). The bottom row (Rerun, Kit) keeps the 221px
56+
height set above. */
5557
.viz-hero-row-top.viz-grid-stretch.viz-grid-hero-tiles .viz-hero-wrap.viz-crop-top25 { height:206px; }
5658
.viz-hero-row-top.viz-grid-stretch.viz-grid-hero-tiles .viz-hero-wrap.viz-crop-top25 video { margin-top:-60px; }
5759
.viz-hero-row-top.viz-grid-stretch.viz-grid-hero-tiles .viz-hero-wrap.viz-crop-mixed { height:206px; }

0 commit comments

Comments
 (0)