Skip to content

Commit bd05cad

Browse files
committed
Assert the pinned Newton release in the wheel install test
The install test pins the exact Newton version the wheel must resolve, and the literal still named the git-pin build develop carries (1.6.0.dev0). This branch pins the 1.6.0rc1 release, so the assertion failed in Installation Tests (ARM) even though the wheel resolved newton==1.6.0rc1 correctly.
1 parent 76ca82a commit bd05cad

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

source/isaaclab/test/install_ci/uv_pip/test_uv_pip_install_isaaclab_all_trains_cartpole.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
Reinstall AFTER the wheel install: unsafe-best-match re-resolves torch from PyPI to CPU.)
1616
- (aarch64 only) export LD_PRELOAD=/lib/aarch64-linux-gnu/libgomp.so.1
1717
Tests:
18-
- python -c "import importlib.metadata as m; assert m.version('newton') == '1.6.0.dev0'"
19-
-> verify the wheel resolves the pinned Newton 1.6 development build
18+
- python -c "import importlib.metadata as m; assert m.version('newton') == '1.6.0rc1'"
19+
-> verify the wheel resolves the pinned Newton release
2020
- uv run isaaclab train --rl_library rsl_rl --task Isaac-Cartpole-Direct --num_envs 16
2121
presets=newton_mjwarp --max_iterations 5; uv run isaaclab train --rl_library rsl_rl
2222
--task Isaac-Cartpole-Camera-Direct --num_envs 16 presets=newton_mjwarp,newton_renderer --max_iterations 2
@@ -57,7 +57,7 @@ def test_uv_pip_install_isaaclab_all_trains_cartpole(self, isaaclab_root, wheel,
5757
assert result.returncode == 0, f"uv pip install {wheel}[all] failed:\n{result.stdout}\n{result.stderr}"
5858

5959
result = self.run_in_uv_env(
60-
["python", "-c", "import importlib.metadata as m; assert m.version('newton') == '1.6.0.dev0'"],
60+
["python", "-c", "import importlib.metadata as m; assert m.version('newton') == '1.6.0rc1'"],
6161
cwd=isaaclab_root,
6262
)
6363
assert result.returncode == 0, (

0 commit comments

Comments
 (0)