Commit c295669
committed
Reject writes to the read-only DOF drive type attribute
ovphysx documents ARTICULATION_DOF_DRIVE_TYPE as read-only, but the attribute
was missing from _READ_ONLY_NAMES, so set_attribute accepted writes to it and
forwarded them to the binding instead of raising.
An audit of the whole classification against the wheel's type table found this
to be the only gap: of the twenty-one types ovphysx documents as read-only,
twenty were already classified, and no member was misclassified.
This is a behavior change. Writes to articulation_dof_drive_type that were
previously accepted now raise OvPhysxView.ReadOnlyAttribute. Drive type is
authored through the USD drive schema, not the tensor path.
The existing read-only behavior test is parameterized over the expected
inventory, so adding the name there also asserts that a write raises and
leaves no binding behind.1 parent f1358cc commit c295669
3 files changed
Lines changed: 9 additions & 0 deletions
File tree
- source/isaaclab_ov
- changelog.d
- isaaclab_ov/sim/views
- test/sim
Lines changed: 6 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
| 82 | + | |
82 | 83 | | |
83 | 84 | | |
84 | 85 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
| 57 | + | |
57 | 58 | | |
58 | 59 | | |
59 | 60 | | |
| |||
243 | 244 | | |
244 | 245 | | |
245 | 246 | | |
| 247 | + | |
246 | 248 | | |
247 | 249 | | |
248 | 250 | | |
| |||
0 commit comments