Commit f86b4e1
authored
Centralize shared physics preset ownership (#7301)
# Description
Centralize backend physics presets at task-family composition roots so
robot-specific files own only genuinely robot-specific scalar
configuration. Standardize Newton MJWarp velocity environments on two
physics substeps at the shared family boundary.
- Move the Kuka Allegro OvPhysX capacity settings into the shared lift
`PhysicsCfg` and remove `KukaAllegroPhysicsCfg`.
- Move the SO-101 articulation contact ordering setting into the shared
stack `PhysicsCfg` and remove `SO101StackPhysicsCfg`.
- Make `RoughPhysicsCfg` own the shared PhysX, MJWarp, and Kamino
alternatives once.
- Set the shared velocity MJWarp configuration to `num_substeps=2` and
remove every robot-specific substep assignment.
- Remove the nine flat-locomotion `PhysicsCfg(RoughPhysicsCfg)`
wrappers. Their environment configs now mutate only robot-specific
MJWarp values on the inherited `RoughPhysicsCfg` instance.
- Preserve shared Newton contact, collision-pipeline, and shape settings
instead of replacing the whole shared alternative in robot-specific
files.
- Add an `isaaclab_tasks` major changelog fragment for the shared
two-substep behavior change.
No additional dependencies are required.
## Type of change
- Refactor: centralize physics-preset ownership.
- Breaking behavior change: Newton MJWarp velocity environments now use
two physics substeps.
## Validation
- Existing focused lift, stack, velocity, and camera preset tests: 15
passed before the substep follow-up.
- Focused velocity Newton config test after the substep follow-up: 1
passed.
- Registered task preset-selection check: passed across the task
registry.
- Runtime configuration compatibility checks: 31 passed.
- Structural audit confirms there is no
`PhysicsCfg(SomeOtherPhysicsCfg)` inheritance under `isaaclab_tasks`.
- Structural audit confirms no core/contrib robot-specific velocity
config assigns `.num_substeps`.
- Direct config audit confirms all ten affected concrete core/contrib
velocity configs resolve MJWarp with two substeps.
- `uv run --frozen isaaclab -f`: Ruff, formatting, and applicable source
checks passed; the repository-wide changelog gate still reports
pre-existing missing or modified fragments in untouched packages.
- Additional preset CLI run: 26 passed; one could not complete because
Isaac Sim requested interactive NVIDIA EULA acceptance, which was not
accepted automatically.
## Screenshots
Not applicable.
## Checklist
- [x] Physics preset ownership is centralized without a compatibility
layer.
- [x] The shared two-substep behavior change is recorded explicitly.
- [x] Existing tests cover preset construction and selection.
- [x] No test files were added or changed.
- [x] An `isaaclab_tasks` major changelog fragment is included.
- [x] No additional documentation changes are needed.1 parent 9f65e3d commit f86b4e1
21 files changed
Lines changed: 76 additions & 316 deletions
File tree
- source
- isaaclab_tasks
- changelog.d
- isaaclab_tasks
- contrib
- stack
- config/so101
- velocity/config
- a1
- anymal_b
- anymal_c
- go1
- spot
- core
- lift
- config/kuka_allegro
- velocity
- config
- anymal_d
- cassie
- g1
- go2
- h1
- isaaclab_visualizers
- changelog.d
- test/golden_images/anymal_d
Lines changed: 5 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
Lines changed: 0 additions & 21 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
8 | 7 | | |
9 | 8 | | |
10 | 9 | | |
11 | 10 | | |
12 | | - | |
13 | 11 | | |
14 | 12 | | |
15 | 13 | | |
| |||
52 | 50 | | |
53 | 51 | | |
54 | 52 | | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | 53 | | |
71 | 54 | | |
72 | 55 | | |
| |||
144 | 127 | | |
145 | 128 | | |
146 | 129 | | |
147 | | - | |
148 | | - | |
149 | | - | |
150 | | - | |
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
296 | 296 | | |
297 | 297 | | |
298 | 298 | | |
| 299 | + | |
| 300 | + | |
299 | 301 | | |
300 | 302 | | |
301 | 303 | | |
| |||
Lines changed: 5 additions & 30 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | 6 | | |
13 | 7 | | |
14 | | - | |
15 | | - | |
16 | 8 | | |
17 | 9 | | |
18 | 10 | | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | 11 | | |
40 | 12 | | |
41 | | - | |
42 | | - | |
43 | 13 | | |
44 | 14 | | |
45 | 15 | | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
46 | 21 | | |
47 | 22 | | |
48 | 23 | | |
| |||
Lines changed: 7 additions & 30 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | 6 | | |
13 | 7 | | |
14 | | - | |
15 | | - | |
16 | 8 | | |
17 | 9 | | |
18 | 10 | | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | 11 | | |
40 | 12 | | |
41 | | - | |
42 | | - | |
43 | 13 | | |
44 | 14 | | |
45 | 15 | | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
46 | 23 | | |
47 | 24 | | |
48 | 25 | | |
| |||
Lines changed: 7 additions & 30 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | 6 | | |
13 | 7 | | |
14 | | - | |
15 | | - | |
16 | 8 | | |
17 | 9 | | |
18 | 10 | | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | 11 | | |
40 | 12 | | |
41 | | - | |
42 | | - | |
43 | 13 | | |
44 | 14 | | |
45 | 15 | | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
46 | 23 | | |
47 | 24 | | |
48 | 25 | | |
| |||
Lines changed: 5 additions & 30 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | 6 | | |
13 | 7 | | |
14 | | - | |
15 | | - | |
16 | 8 | | |
17 | 9 | | |
18 | 10 | | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | 11 | | |
40 | 12 | | |
41 | | - | |
42 | | - | |
43 | 13 | | |
44 | 14 | | |
45 | 15 | | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
46 | 21 | | |
47 | 22 | | |
48 | 23 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | | - | |
| 52 | + | |
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
| |||
Lines changed: 0 additions & 18 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
7 | | - | |
8 | 6 | | |
9 | 7 | | |
10 | 8 | | |
11 | 9 | | |
12 | | - | |
13 | 10 | | |
14 | 11 | | |
15 | 12 | | |
| |||
24 | 21 | | |
25 | 22 | | |
26 | 23 | | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | 24 | | |
42 | 25 | | |
43 | 26 | | |
| |||
105 | 88 | | |
106 | 89 | | |
107 | 90 | | |
108 | | - | |
109 | 91 | | |
110 | 92 | | |
111 | 93 | | |
| |||
Lines changed: 6 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| 9 | + | |
9 | 10 | | |
10 | 11 | | |
11 | 12 | | |
| |||
490 | 491 | | |
491 | 492 | | |
492 | 493 | | |
| 494 | + | |
| 495 | + | |
| 496 | + | |
| 497 | + | |
493 | 498 | | |
494 | 499 | | |
495 | 500 | | |
| |||
509 | 514 | | |
510 | 515 | | |
511 | 516 | | |
512 | | - | |
| 517 | + | |
513 | 518 | | |
514 | 519 | | |
515 | 520 | | |
| |||
0 commit comments