Skip to content

Commit fddc02f

Browse files
committed
Fix Factory preset and smoke CI
1 parent f94896f commit fddc02f

3 files changed

Lines changed: 12 additions & 4 deletions

File tree

source/isaaclab_tasks/isaaclab_tasks/contrib/nist/factory_assets_cfg.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ class _SocketCollisionPropsCfg(PresetCfg):
4242
sdf_narrow_band_inner=-0.005,
4343
sdf_narrow_band_outer=0.005,
4444
)
45-
physx = default
45+
isaacsim_physx = default
46+
physx = isaacsim_physx
4647

4748

4849
@configclass
@@ -58,7 +59,8 @@ class _PlugCollisionPropsCfg(PresetCfg):
5859
sdf_narrow_band_inner=-0.005,
5960
sdf_narrow_band_outer=0.005,
6061
)
61-
physx = default
62+
isaacsim_physx = default
63+
physx = isaacsim_physx
6264

6365

6466
ASSEMBLY_SOCKET_COLLISION_PROPS_CFG = _SocketCollisionPropsCfg()

source/isaaclab_tasks/isaaclab_tasks/contrib/nist/factory_scenes_cfg.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717
from isaaclab_tasks.contrib.nist import factory_assets_cfg as assets
1818
from isaaclab_tasks.utils import PresetCfg, preset
1919

20+
_FRANKA_PANDA_PHYSX_CFG = assets.FRANKA_PANDA_PHYSX_CFG.replace(prim_path="{ENV_REGEX_NS}/Robot")
21+
2022

2123
@configclass
2224
class FactorySceneBase(InteractiveSceneCfg):
@@ -27,8 +29,9 @@ class FactorySceneBase(InteractiveSceneCfg):
2729
table = assets.TABLE_CFG
2830
nistboard = assets.NISTBOARD_CFG
2931
robot: ArticulationCfg = preset( # type: ignore[assignment]
30-
default=assets.FRANKA_PANDA_PHYSX_CFG.replace(prim_path="{ENV_REGEX_NS}/Robot"),
31-
physx=assets.FRANKA_PANDA_PHYSX_CFG.replace(prim_path="{ENV_REGEX_NS}/Robot"),
32+
default=_FRANKA_PANDA_PHYSX_CFG,
33+
isaacsim_physx=_FRANKA_PANDA_PHYSX_CFG,
34+
physx=_FRANKA_PANDA_PHYSX_CFG,
3235
newton_mjwarp=assets.FRANKA_PANDA_NEWTON_CFG.replace(prim_path="{ENV_REGEX_NS}/Robot"),
3336
)
3437
dome_light = assets.DOMELIGHT_CFG

source/isaaclab_tasks/test/env_test_utils.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -457,6 +457,9 @@ def _check_random_actions(
457457
# the scene config with the preset's default num_envs.
458458
if num_envs is not None:
459459
env_cfg.scene.num_envs = num_envs
460+
reset_event = getattr(env_cfg.events, "reset_strategies", None)
461+
if reset_event is not None and "state_table_size" in reset_event.params:
462+
reset_event.params["state_table_size"] = min(32, reset_event.params["state_table_size"])
460463
# set config args
461464
env_cfg.sim.create_stage_in_memory = create_stage_in_memory
462465
if disable_clone_in_fabric:

0 commit comments

Comments
 (0)