Skip to content

Commit fe90744

Browse files
committed
remove redundant mock tests
1 parent 08a398d commit fe90744

1 file changed

Lines changed: 1 addition & 32 deletions

File tree

source/isaaclab/test/renderers/test_renderer_factory.py

Lines changed: 1 addition & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
"""Tests for the Renderer factory."""
77

8-
from unittest.mock import MagicMock, Mock, patch
8+
from unittest.mock import Mock
99

1010
import pytest
1111

@@ -93,34 +93,3 @@ def test_renderer_factory_returns_correct_backend(cfg_cls, expected_class_name):
9393
Renderer._registry[backend] = original
9494
else:
9595
Renderer._registry.pop(backend, None)
96-
97-
98-
@pytest.mark.parametrize(
99-
"cfg_cls,expected_class_name",
100-
[
101-
(IsaacRtxRendererCfg, "IsaacRtxRenderer"),
102-
(NewtonWarpRendererCfg, "NewtonWarpRenderer"),
103-
(OVRTXRendererCfg, "OVRTXRenderer"),
104-
],
105-
ids=["IsaacRtxRendererCfg", "NewtonWarpRendererCfg", "OVRTXRendererCfg"],
106-
)
107-
def test_renderer_factory_instantiation_backends(cfg_cls, expected_class_name):
108-
"""Renderer(cfg) with registry returns correct backend class.
109-
NewtonWarpRenderer needs SimulationContext and SensorTiledCamera mocked."""
110-
cfg = cfg_cls()
111-
if cfg_cls is NewtonWarpRendererCfg:
112-
mock_provider = MagicMock()
113-
mock_provider.get_newton_model.return_value = MagicMock()
114-
mock_ctx = MagicMock()
115-
mock_ctx.initialize_scene_data_provider.return_value = mock_provider
116-
with (
117-
patch("isaaclab_newton.renderers.newton_warp_renderer.SimulationContext") as mock_sc_cls,
118-
patch("isaaclab_newton.renderers.newton_warp_renderer.newton.sensors.SensorTiledCamera") as mock_stc,
119-
):
120-
mock_sc_cls.instance.return_value = mock_ctx
121-
mock_stc.return_value = MagicMock()
122-
renderer = Renderer(cfg)
123-
else:
124-
renderer = Renderer(cfg)
125-
assert type(renderer).__name__ == expected_class_name
126-
assert isinstance(renderer, BaseRenderer)

0 commit comments

Comments
 (0)