Skip to content

Installation guide - replace curly bracket with parantheses - #5046

Closed
smollerNV wants to merge 4 commits into
isaac-sim:developfrom
smollerNV:patch-1
Closed

Installation guide - replace curly bracket with parantheses#5046
smollerNV wants to merge 4 commits into
isaac-sim:developfrom
smollerNV:patch-1

Conversation

@smollerNV

Copy link
Copy Markdown

To correctly set the path for the environment variable, the pwk command must be enclosed in parantheses rather than curly brackets.

Type of change

  • Documentation update

nv-caelan and others added 4 commits March 7, 2026 20:23
…ck orders (isaac-sim#4875)

# Description

This PR adds 4 new Isaac-Stack-Cube-Franka-IK-Rel-v0 task variants
corresponding to stacking [Red, Green], [Red, Green, Blue], [Blue,
Green], and [Blue, Green, Red]. The objective is to create a test bed
for different success conditions in the same scene.

## Type of change

- New feature (non-breaking change which adds functionality)

## Checklist

- [x] I have read and understood the [contribution
guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html)
- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [x] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there
Just a few docstring changes for consistency. Low priority and low risk.

## Type of change

- Documentation update

## Checklist

- [x] I have read and understood the [contribution
guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html)
- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
# Description

Updates Newton docs on main for 3.0 beta changes


## Type of change

- Documentation update


## Checklist

- [x] I have read and understood the [contribution
guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html)
- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [ ] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there

<!--
As you go through the checklist above, you can mark something as done by
putting an x character in it

For example,
- [x] I have done this task
- [ ] I have not done this task
-->
This is the correct way to make it execute the command.

Signed-off-by: smollerNV <164020096+smollerNV@users.noreply.github.com>
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Mar 17, 2026
@greptile-apps

greptile-apps Bot commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR fixes a bash syntax bug in the source installation guide. The export ISAACSIM_PATH line previously used "${pwd}/_build/linux-x86_64/release", which performs variable expansion on a variable named pwd (which is empty by default), resulting in a broken path. The fix correctly uses "$(pwd)/_build/linux-x86_64/release", which performs command substitution — executing the pwd command to obtain the current working directory.

  • Fixes ${pwd}$(pwd) on the ISAACSIM_PATH export line in the Linux tab of the installation guide
  • The Windows equivalent (%cd%) in the same file was already correct and is unchanged
  • The fix is accurate and matches the intended behavior described in the PR

Confidence Score: 5/5

  • This PR is safe to merge — it is a correct, minimal documentation fix with no risk.
  • The change is a single-line correction of a bash syntax error in a .rst documentation file. It introduces no logic changes, no new dependencies, and the fix ($(pwd) vs ${pwd}) is unambiguously correct for bash command substitution.
  • No files require special attention.

Important Files Changed

Filename Overview
docs/source/setup/installation/source_installation.rst Corrects bash command substitution syntax from ${pwd} (variable expansion) to $(pwd) (command substitution) when setting ISAACSIM_PATH.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["User runs: export ISAACSIM_PATH=..."] --> B{Syntax used}
    B -- "Before: \${pwd}" --> C["Shell looks up variable 'pwd'\n(empty string by default)"]
    C --> D["ISAACSIM_PATH = '/_build/linux-x86_64/release'\n❌ Broken path"]
    B -- "After: \$(pwd)" --> E["Shell executes 'pwd' command\nreturns current directory"]
    E --> F["ISAACSIM_PATH = '/home/user/isaac-sim/_build/linux-x86_64/release'\n✅ Correct path"]
Loading

Last reviewed commit: bc41ffc

@myurasov-nv

Copy link
Copy Markdown
Member

@smollerNV I think it makes more sense to add this to develop branch.

@kellyguo11
kellyguo11 changed the base branch from main to develop March 29, 2026 04:49
@AntoineRichard

AntoineRichard commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

Hi @smollerNV — thanks for putting this one up! 🙏

We're doing a cleanup pass over the Isaac Lab PR backlog, which had grown past 400 open pull requests, and we're closing out the ones that have gone quiet so the queue is reviewable again.

Why this PR is being closed: Here is exactly what we found on this PR when we reviewed the backlog:

Opened 2026-03-17 (about 5 months ago)
Last commit on the branch 2026-03-17
Last activity from the author about 5 months ago
Target branch develop
Review status Never reviewed by a maintainer — nobody on the team got to it. Sorry about that.
Merge status Unknown
Size 4 commit(s), 15 file(s) changed, +251 / -134

It was picked up by the sweep because it has been open for about 5 months. It was then put in the "close" bucket because the author has been silent for about 5 months — which is the signal we used to tell apart pull requests that are still being worked on from ones that have genuinely been set aside.

We deliberately did not close pull requests that were approved and ready to land, or that were small and clearly still fixing a live bug — there were 27 of those, and we are merging them rather than closing them.

No judgement on the change itself — this is purely backlog hygiene.

If this is still wanted, please reopen it or re-submit against develop. 💚


🤖 This comment was drafted with AI assistance as part of a maintainer-led sweep of the Isaac Lab pull request backlog. A maintainer is behind this cleanup — but if this closure looks wrong, it may well be, so please push back and we'll take another look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants