Installation guide - replace curly bracket with parantheses - #5046
Installation guide - replace curly bracket with parantheses#5046smollerNV wants to merge 4 commits into
Conversation
…ck orders (isaac-sim#4875) # Description This PR adds 4 new Isaac-Stack-Cube-Franka-IK-Rel-v0 task variants corresponding to stacking [Red, Green], [Red, Green, Blue], [Blue, Green], and [Blue, Green, Red]. The objective is to create a test bed for different success conditions in the same scene. ## Type of change - New feature (non-breaking change which adds functionality) ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Just a few docstring changes for consistency. Low priority and low risk. ## Type of change - Documentation update ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings
# Description Updates Newton docs on main for 3.0 beta changes ## Type of change - Documentation update ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task -->
This is the correct way to make it execute the command. Signed-off-by: smollerNV <164020096+smollerNV@users.noreply.github.com>
Greptile SummaryThis PR fixes a bash syntax bug in the source installation guide. The
Confidence Score: 5/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["User runs: export ISAACSIM_PATH=..."] --> B{Syntax used}
B -- "Before: \${pwd}" --> C["Shell looks up variable 'pwd'\n(empty string by default)"]
C --> D["ISAACSIM_PATH = '/_build/linux-x86_64/release'\n❌ Broken path"]
B -- "After: \$(pwd)" --> E["Shell executes 'pwd' command\nreturns current directory"]
E --> F["ISAACSIM_PATH = '/home/user/isaac-sim/_build/linux-x86_64/release'\n✅ Correct path"]
Last reviewed commit: bc41ffc |
|
@smollerNV I think it makes more sense to add this to develop branch. |
|
Hi @smollerNV — thanks for putting this one up! 🙏 We're doing a cleanup pass over the Isaac Lab PR backlog, which had grown past 400 open pull requests, and we're closing out the ones that have gone quiet so the queue is reviewable again. Why this PR is being closed: Here is exactly what we found on this PR when we reviewed the backlog:
It was picked up by the sweep because it has been open for about 5 months. It was then put in the "close" bucket because the author has been silent for about 5 months — which is the signal we used to tell apart pull requests that are still being worked on from ones that have genuinely been set aside. We deliberately did not close pull requests that were approved and ready to land, or that were small and clearly still fixing a live bug — there were 27 of those, and we are merging them rather than closing them. No judgement on the change itself — this is purely backlog hygiene. If this is still wanted, please reopen it or re-submit against 🤖 This comment was drafted with AI assistance as part of a maintainer-led sweep of the Isaac Lab pull request backlog. A maintainer is behind this cleanup — but if this closure looks wrong, it may well be, so please push back and we'll take another look. |
To correctly set the path for the environment variable, the pwk command must be enclosed in parantheses rather than curly brackets.
Type of change