Bump usd-core dependency to 26.05 to fix USD physics crash - #6521
Bump usd-core dependency to 26.05 to fix USD physics crash#6521mataylor-nvidia wants to merge 35 commits into
Conversation
Resolves a fatal crash in libusd_ms triggered by LoadUsdPhysicsFromRange, caused by ABI incompatibility in the 25.11 USD library (nvbugspro #6441062).
|
The ovphysx_manager.py comment referencing |
Greptile SummaryThis PR updates the kitless USD dependency to the USD 26 line. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (10): Last reviewed commit: "Surface read-only pxr promotion failure ..." | Re-trigger Greptile |
Update the hardcoded usd_core_version fixture value to 26.05 to match the dependency pin bumped in the previous commit.
…nments The previous fix uninstalled usd-core when omni.usd.libs was detected, which removed pxr from sys.path entirely. OV tests run via pytest without Kit startup, so omni.usd.libs pxr is never loaded by the extension system, causing ModuleNotFoundError: No module named 'pxr'. Replace _maybe_uninstall_kitless_pxr with _maybe_configure_ov_pxr, which installs a .pth file in site-packages instead. The .pth file prepends omni.usd.libs to sys.path at Python startup, ensuring the NVIDIA-patched pxr (which removes the UsdVol ParticleField alias) is found before usd-core. usd-core stays installed as a fallback for kit-less environments.
|
@greptile review |
| ] | ||
|
|
||
| assert usd_core_dependencies == ["usd-core>=25.11,<26.0 ; platform_machine in 'x86_64 AMD64'"] | ||
| assert usd_core_dependencies == ["usd-core>=26.05,<27.0 ; platform_machine in 'x86_64 AMD64'"] |
There was a problem hiding this comment.
Maybe we can just get rid of these tests, since they're just checking that a hardcoded value is the correct hardcoded value? I don't see anything in this test file that's actually a useful test.
There was a problem hiding this comment.
sure sounds good to me
…IsaacLab into mataylor/bump-usd-26.05
|
Possible issues: Issue 1 — USD schema conflict (without omni.usd.libs in PYTHONPATH): Issue 2 — OmniClient version mismatch (independent, present even after the USD fix): |
|
🤖 AI-assisted review (batch triage of open CI/infra PRs) Closing as superseded: develop has since removed Feel free to reopen if this was closed in error. |
Resolves a fatal crash in libusd_ms triggered by LoadUsdPhysicsFromRange, caused by ABI incompatibility in the 25.11 USD library (nvbugspro #6441062).
Note this fix will work for kitless, but kit brings it's own USD
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change.
Fixes # (OMPE-100515)
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there