-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[Workflow] Add isaacsim source install uv workflow #6762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 10 commits
2122d05
027f84e
cbbfeff
2d73ce0
0e11c5e
9342421
a6cb903
5a5d134
941af6c
120b0b6
2ae5f2c
4b85303
c8ff14a
ca57b17
f77f603
2a96e11
6350bfa
c161dff
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| Added | ||
| ^^^^^ | ||
|
|
||
| * Added the ``--isaacsim_source`` CLI option, which incrementally builds Isaac Sim from a source checkout, | ||
| packages the build as Python wheels, links them into the repository as ``_isaac_sim_wheels``, | ||
| points ``uv`` at that directory through ``find-links`` in ``pyproject.toml``, pins the | ||
| ``isaacsim-local`` extra to the version it built, and re-resolves Isaac Sim from those | ||
| wheels. Run Isaac Lab against the build with ``uv run --extra isaacsim-local``. The pin is | ||
| required because source builds carry pre-release local versions that sort below the published | ||
| release, so an unpinned extra resolves back to the released wheels on ``pypi.nvidia.com``. | ||
| * Added a check to ``--isaacsim_source`` that rejects a stale Isaac Sim ``_build`` tree whose | ||
| packaged Kit kernel does not match the Python ABI its wheel is tagged for, instead of letting | ||
| Isaac Sim fail later with ``No module named 'carb._carb'``. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,6 +17,7 @@ | |
| ) | ||
| from .commands.misc import ( | ||
| command_build_docs, | ||
| command_build_isaacsim, | ||
| command_new, | ||
| command_run_docker, | ||
| command_run_isaacsim, | ||
|
|
@@ -262,6 +263,15 @@ def cli() -> None: | |
| const="env_isaaclab", | ||
| help="Create a new uv environment for Isaac Lab. Default name is 'env_isaaclab'.", | ||
| ) | ||
| parser.add_argument( | ||
| "--isaacsim_source", | ||
| metavar="PATH", | ||
| help=( | ||
| "Build Isaac Sim from the source checkout at PATH, package it as wheels, and link\n" | ||
| "them as '_isaac_sim_wheels' for 'uv run --extra isaacsim-local'.\n" | ||
| "Runs the normal incremental build on every invocation." | ||
| ), | ||
| ) | ||
|
|
||
| args = parser.parse_args() | ||
|
|
||
|
|
@@ -277,6 +287,9 @@ def cli() -> None: | |
| elif args.uv: | ||
| command_setup_uv(args.uv) | ||
|
|
||
| elif args.isaacsim_source: | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔵 Suggestion — This branch sits in the |
||
| command_build_isaacsim(args.isaacsim_source) | ||
|
|
||
| elif args.vscode: | ||
| command_vscode_settings() | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[AI review][Important] This sequence cannot be followed from the stated Isaac Lab root: the clone command creates
./IsaacSim, but this command points at the sibling../IsaacSim. Either clone directly to../IsaacSimor include explicitcdcommands from the common parent directory.