Skip to content

Enable synchronous texture streaming for OVRTX #6957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
huidongc wants to merge 1 commit into from
Closed

Enable synchronous texture streaming for OVRTX #6957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions source/isaaclab_ov/changelog.d/enable-synchronous-texture-streaming.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Changed
^^^^^^^

* Enabled synchronous texture streaming on the internal OVRTX ``RendererConfig`` in
:class:`~isaaclab_ov.renderers.ovrtx_renderer.OVRTXRenderer` via
``texture_streaming_mode=TextureStreamingMode.SYNCHRONOUS`` to improve cross-run
render determinism. Requires ``ovrtx>=0.4.1``.
4 changes: 3 additions & 1 deletion source/isaaclab_ov/isaaclab_ov/renderers/ovrtx_renderer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@
Renderer,
RendererConfig,
Semantic,
TextureStreamingMode,

@greptile-apps greptile-apps Bot Aug 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Dependency permits incompatible OVRTX API

When a supported installation path resolves ovrtx==0.4.0, this unconditional TextureStreamingMode import uses an API that requires 0.4.1, causing the OVRTX renderer module to fail to import. Raise the lower bound in the repository's ov and ovrtx dependency constraints so installations cannot select the incompatible release.

)
except ModuleNotFoundError as exc:
if exc.name != "ovrtx":
Expand All @@ -71,7 +72,7 @@
"The OVRTX renderer requires the optional 'ovrtx' runtime wheel, which is not installed. "
"Run your command with: uv run --extra ovrtx <command> "
"(or, manually: python -m pip install --extra-index-url https://pypi.nvidia.com "
"'ovrtx>=0.4.0,<0.5.0')."
"'ovrtx>=0.4.1,<0.5.0')."
) from exc

from isaaclab.cloner.clone_plan import ClonePlan
Expand Down Expand Up @@ -399,6 +400,7 @@ def __init__(self, cfg: OVRTXRendererCfg):
log_level=self.cfg.log_level,
read_gpu_transforms=_read_gpu_transforms_enabled(),
keep_system_alive=True,
texture_streaming_mode=TextureStreamingMode.SYNCHRONOUS,
)
self._renderer = Renderer(OVRTX_CONFIG)
if not self._renderer:
Expand Down
Loading