Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
# (frozen at 6.1.0-alpha.2). Both images use Isaac Sim's NGC org, which is current and
# which the CI credential can reach.
isaacsim_image_name: nvcr.io/0947644777160149/internal/isaac-sim
# Pinned to the last known-good build; newer ones fail the rendering tests.
isaacsim_image_tag: latest-develop@sha256:71019ff76289be944cc4356323e32d17568ee082228e3bf1ef047b741f4fe380
# Pinned to Isaac Sim commit 307e5486 for reproducible CI.
isaacsim_image_tag: latest-develop@sha256:a13867a6403488a9e640288f96492e6ecd44c3a525b5b85793a2da68fdac48ad
isaaclab_image_name: nvcr.io/0947644777160149/internal/isaac-lab
ovphysx_wheelhouse_image: ""
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Test-only: marked scene-partitioning regression tests as expected failures for NVBug 6264822.
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@
from isaaclab_assets.robots.kuka_allegro import KUKA_ALLEGRO_CFG

_ENV_VAR = "ISAAC_LAB_ENABLE_ISAAC_RTX_PER_ENV_SCENE_PARTITION"
_PARTITION_XFAIL = pytest.mark.xfail(
reason="NVBug 6264822: Kit c0b875cd scene partitioning regression", strict=False, run=False
)
Comment on lines +53 to +55

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Keep quarantined tests executable

Setting run=False prevents both partition-isolation tests from executing, so CI cannot produce an XPASS when NVBug 6264822 is fixed or expose a changed failure mode. Keep the non-strict xfail while allowing the test bodies to run.

Suggested change
_PARTITION_XFAIL = pytest.mark.xfail(
reason="NVBug 6264822: Kit c0b875cd scene partitioning regression", strict=False, run=False
)
_PARTITION_XFAIL = pytest.mark.xfail(
reason="NVBug 6264822: Kit c0b875cd scene partitioning regression", strict=False
)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!



@pytest.fixture()
Expand Down Expand Up @@ -84,6 +87,7 @@ def test_partitioning_disabled_by_default(monkeypatch):


@pytest.mark.isaacsim_ci
@_PARTITION_XFAIL
def test_partitioning_isolates_rigid_object(enable_scene_partition):
"""Per-env :class:`~isaaclab.assets.RigidObject` instances at unique world positions render
as visibly different per-env tiles when RTX honors ``primvars:omni:scenePartition``."""
Expand Down Expand Up @@ -151,6 +155,7 @@ class _Scene(InteractiveSceneCfg):


@pytest.mark.isaacsim_ci
@_PARTITION_XFAIL
def test_partitioning_isolates_articulation(enable_scene_partition):
"""Per-env :class:`~isaaclab.assets.Articulation` instances driven to wildly different joint
poses render as visibly different per-env tiles when RTX honors top-level scene partitions."""
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Test-only: refreshed RTX goldens and bypassed the NVBug 6264822 partition path in registered rendering tests.
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,8 @@ def _collect_camera_outputs(env: object) -> dict[str, dict[str, torch.Tensor]]:


@pytest.mark.parametrize("task_id, presets, env_name", _RENDER_CORRECTNESS_TASK_IDS)
def test_rendering_registered_tasks(task_id: str, presets: str | None, env_name: str, enable_scene_partition):
Comment thread
nvsekkin marked this conversation as resolved.
# TODO: Restore enable_scene_partition after NVBug 6264822 is fixed.
def test_rendering_registered_tasks(task_id: str, presets: str | None, env_name: str):
"""Test registered tasks rendering correctness."""
env = None

Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Test-only: refreshed RTX visualizer goldens for the updated Isaac Sim renderer.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading