Skip to content

[Cleanup] Remove unused directory and alias functions - #6988

Merged
StafaH merged 2 commits into
isaac-sim:developfrom
StafaH:mh/cleanup_video_alias
Aug 10, 2026
Merged

[Cleanup] Remove unused directory and alias functions#6988
StafaH merged 2 commits into
isaac-sim:developfrom
StafaH:mh/cleanup_video_alias

Conversation

@StafaH

@StafaH StafaH commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Description

Remove unused functions and empty video recording submodule

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a changelog fragment under source/<pkg>/changelog.d/ for every touched package (do not edit CHANGELOG.rst or bump extension.toml — CI handles that)
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@StafaH
StafaH requested a review from a team August 8, 2026 23:37
@github-actions github-actions Bot added the isaac-lab Related to Isaac Lab team label Aug 8, 2026
@greptile-apps

greptile-apps Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Removes unused physics and renderer capability methods and deletes empty video-recording packages.

  • Removes capability APIs and their backend overrides from IsaacLab, Newton, OV, and PhysX.
  • Removes empty Newton and PhysX video-recording package initializers.
  • Adds major-version changelog fragments for each affected package.

Confidence Score: 5/5

The PR appears safe to merge because the removed methods and packages have no remaining repository callers, imports, or registration dependencies.

The removals are applied consistently across base classes and backend overrides, while targeted checks found no reachable in-repository use of the deleted APIs or package paths.

Important Files Changed

Filename Overview
source/isaaclab/isaaclab/physics/physics_manager.py Removes the unused implicit-damping capability method; no repository callers remain.
source/isaaclab/isaaclab/renderers/base_renderer.py Removes the unused temporal-camera-data capability method, with corresponding backend overrides removed consistently.
source/isaaclab_newton/isaaclab_newton/video_recording/init.py Deletes an empty, unreferenced package initializer with no registration side effects.
source/isaaclab_physx/isaaclab_physx/video_recording/init.py Deletes an empty, unreferenced package initializer after its prior recording hook dependency had already been removed.

Reviews (1): Last reviewed commit: "Remove unused directory and functions" | Re-trigger Greptile

@isaaclab-review-bot isaaclab-review-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isaac Lab Review Bot

This PR removes two public capability classmethods and their backend overrides, plus two empty video-recording packages. The capability methods are deleted without the prior deprecation required by repository policy.

  • Design and architecture: Removing the capability-probe layer is internally consistent because the base methods and all shown backend overrides are removed together. However, architectural cleanup does not bypass the compatibility policy for public base-class extension points.
  • API: PhysicsManager.provides_implicit_damping and BaseRenderer.provides_temporal_camera_data are documented public classmethods that external backends may call or override. They must be deprecated for a release before removal; the changelog’s major bump and migration note do not replace that deprecation period.
  • Implementation: The method deletions are localized and corresponding in-tree overrides are removed. Restore the base-class methods with deprecation warnings, classify the current changelog entry as Deprecated, and defer deletion until a later release.

Minor fixes needed. Posted 1 actionable finding inline.

Automated review; human maintainers own approval decisions.

Removed
^^^^^^^

* Removed the unused ``PhysicsManager.provides_implicit_damping`` and

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Warning · Api — Public capability methods removed without prior deprecation

PhysicsManager.provides_implicit_damping and BaseRenderer.provides_temporal_camera_data are public, documented classmethods on base classes that out-of-tree physics backends and renderers can override or call; both are deleted outright here. Repository guidelines require deprecating public API symbols in a prior release before removal. Keep the base-class implementations with a deprecation warning and file this fragment under Deprecated, then delete them in a later release.

@StafaH
StafaH merged commit 6a6e165 into isaac-sim:develop Aug 10, 2026
151 of 156 checks passed
@StafaH
StafaH deleted the mh/cleanup_video_alias branch August 13, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

isaac-lab Related to Isaac Lab team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants