Retune Newton and PhysX environments for Franka cloth lift - #6998
Conversation
Greptile SummaryThis PR adds PhysX presets for the Franka cloth-lifting tasks while retaining Newton as the default.
Confidence Score: 5/5The PR appears safe to merge, with the PhysX preset wiring and scripted-demo changes consistent with existing deformable-task conventions. The new backend aliases resolve coherently across physics, deformable, and scene configurations; PhysX scenes disable unsupported replication, Newton remains the default, and no concrete blocking or non-blocking defect remains. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
CLI["Task + preset selection"] --> Resolve["Resolve task configuration"]
Resolve --> Newton["newton_mjwarp_vbd_proxy<br/>default"]
Resolve --> PhysX["isaacsim_physx"]
Newton --> NewtonScene["Replicated cloth scene<br/>Newton material"]
PhysX --> PhysXScene["Non-replicated cloth scene<br/>PhysX material and collision"]
NewtonScene --> Env["Franka cloth environment"]
PhysXScene --> Env
Env --> Demo["IK state-machine demo"]
Env --> Train["RL workflow"]
Env --> Camera["Camera task variant"]
Reviews (1): Last reviewed commit: "Add Newton changelog skip fragment" | Re-trigger Greptile |
There was a problem hiding this comment.
Isaac Lab Review Bot
The cloth-specific PhysX preset architecture and documentation are consistent, but two changes in the shared Franka soft-task configuration alter existing soft-beam PhysX and IK behavior without being required for cloth support or recorded in the changelog.
- Design and architecture: The backend-specific physics, deformable, and scene presets correctly isolate cloth configuration and disable scene replication for PhysX deformables. However, the shared soft-beam base still receives two cloth-adjacent tuning changes even though the cloth environment overrides both relevant configuration paths.
- API: The advertised
isaacsim_physx,physx, andnewton_mjwarp_vbd_proxypreset keys agree across task configuration, documentation, and browser data. The changelog covers newly added cloth support but does not disclose the changed PhysX contact defaults or IK gripper close width for the existing soft-beam tasks. - Implementation:
FrankaClothEnvCfg.__post_init__installs its own physics configuration and overrides the cloth IK close command to 0.0. Consequently, removing the shared PhysX friction parameters and changing the shared IK close width to 0.01 affect the soft-beam task rather than implementing cloth support; these values should be restored or the behavioral changes explicitly documented.
Minor fixes needed. Posted 2 actionable findings inline.
Automated review; human maintainers own approval decisions.
| friction_offset_threshold=0.005, | ||
| friction_correlation_distance=0.01, | ||
| ) | ||
| isaacsim_physx: PhysxCfg = PhysxCfg() |
There was a problem hiding this comment.
🟡 Warning · Implementation — Soft-beam PhysX friction tuning silently dropped
FrankaClothEnvCfg.__post_init__ replaces sim.physics with the cloth module's own PhysicsCfg, so this preset is consumed only by the already-released Isaac-Lift-Soft-Franka(-Camera) tasks. Clearing friction_offset_threshold=0.005 and friction_correlation_distance=0.01 reverts that task's PhysX contact tuning to defaults, is not needed for cloth PhysX support, and is not covered by the Added-only changelog fragment. Restore the values or record the change under Changed.
| @@ -369,7 +366,7 @@ class _IkActionsCfg: | |||
| asset_name="robot", | |||
| joint_names=["panda_finger_joint1"], | |||
| open_command_expr={"panda_finger_joint1": 0.04}, | |||
| close_command_expr={"panda_finger_joint1": 0.015}, | |||
| close_command_expr={"panda_finger_joint1": 0.01}, | |||
There was a problem hiding this comment.
🔵 Suggestion · Implementation — Shared IK gripper close width changed
_IkActionsCfg is shared with the soft-beam task, and the cloth env already overrides close_command_expr to 0.0 in its __post_init__. Narrowing the shared default from 0.015 to 0.01 therefore only alters the existing beam task's scripted grasp. Keep the shared value at 0.015 and confine cloth-specific tuning to the cloth config, or document the beam behavior change.
|
looks like a failure in rendering correctness test |
5fd4ca0 to
7828001
Compare
…olumetric for physx, match newton.
# Description Restore meaningful Franka cloth motion-vector regression coverage after #6998 changed the task to clamp the cloth between supports. - Raise the cloth by 1 cm for the Newton + OVRTX motion-vector case so it undergoes visible motion. - Preserve the OVRTX third-frame workaround tracked by NVBug 6565960. - Re-enable Newton + OVRTX cloth motion-vector coverage and refresh its golden. - Scope the controlled fall and extra frame strictly to Newton + OVRTX, leaving all other backend/renderer combinations unchanged. - Keep Newton + Isaac RTX quarantined under its existing nondeterminism policy. The third-frame workaround can be removed after the OVRTX fix is available in a post-GA release. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Screenshots Updated Newton + OVRTX motion-vector golden:  ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have added a changelog fragment under `source/<pkg>/changelog.d/` for every touched package (do **not** edit `CHANGELOG.rst` or bump `extension.toml` — CI handles that) - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there ## Release backport - [x] <!-- backport-active-release --> Backport this pull request to the active release branch after it merges into `develop`
# Description Restore meaningful Franka cloth motion-vector regression coverage after #6998 changed the task to clamp the cloth between supports. - Raise the cloth by 1 cm for the Newton + OVRTX motion-vector case so it undergoes visible motion. - Preserve the OVRTX third-frame workaround tracked by NVBug 6565960. - Re-enable Newton + OVRTX cloth motion-vector coverage and refresh its golden. - Scope the controlled fall and extra frame strictly to Newton + OVRTX, leaving all other backend/renderer combinations unchanged. - Keep Newton + Isaac RTX quarantined under its existing nondeterminism policy. The third-frame workaround can be removed after the OVRTX fix is available in a post-GA release. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Screenshots Updated Newton + OVRTX motion-vector golden:  ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have added a changelog fragment under `source/<pkg>/changelog.d/` for every touched package (do **not** edit `CHANGELOG.rst` or bump `extension.toml` — CI handles that) - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there ## Release backport - [x] <!-- backport-active-release --> Backport this pull request to the active release branch after it merges into `develop` (cherry picked from commit 553efa6)
Description
Adds
isaacsim_physxsupport to the Franka cloth lift tasks as a follow-up to #6831, while retainingnewton_mjwarp_vbd_proxyas the default physics preset.This PR:
NewtonCfg.simplify_meshes, which was reintroduced during branch integration, and records the Newton-only cleanup with a skip fragment.No new dependencies are required.
Validation
uv run isaaclab -fuv run python tools/changelog/cli.py check developin a clean cloneuv run --isolated --extra test -- make -C docs current-docsin a clean clonePYTHONPATH="$PWD/source/isaaclab_tasks:$PYTHONPATH" uv run python scripts/environments/state_machine/lift_franka_soft.py --task Isaac-Lift-Cloth-Franka --num_envs 1 --num_steps 500 --viz none presets=isaacsim_physxType of change
Screenshots
Not applicable.
Checklist
uv run isaaclab -fsource/<pkg>/changelog.d/for every touched packageCONTRIBUTORS.mdor my name already exists there