-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Retune Newton and PhysX environments for Franka cloth lift #6998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
c1cd521
1bd5820
2a9e961
f8e2858
2218401
edf4a5a
ba97ac6
ccfd5cc
4908a39
95b0ce6
1e5d50d
6f8ad2b
016453c
401f1d7
529a94b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Internal: restored the already released removal of ``NewtonCfg.simplify_meshes`` after a merge reintroduced the field. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| Added | ||
| ^^^^^ | ||
|
|
||
| * Added ``isaacsim_physx`` support to the Franka cloth lift tasks. | ||
|
|
||
| Fixed | ||
| ^^^^^ | ||
|
|
||
| * Fixed success table visualization markers appearing at the world origin | ||
| before the first environment step. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -182,10 +182,7 @@ class PhysicsCfg(PresetCfg): | |
| num_substeps=2, | ||
| ) | ||
|
|
||
| isaacsim_physx: PhysxCfg = PhysxCfg( | ||
| friction_offset_threshold=0.005, | ||
| friction_correlation_distance=0.01, | ||
| ) | ||
| isaacsim_physx: PhysxCfg = PhysxCfg() | ||
|
|
||
| physx: PhysxAutoCfg = PhysxAutoCfg(isaacsim_physx=isaacsim_physx) | ||
|
|
||
|
|
@@ -369,7 +366,7 @@ class _IkActionsCfg: | |
| asset_name="robot", | ||
| joint_names=["panda_finger_joint1"], | ||
| open_command_expr={"panda_finger_joint1": 0.04}, | ||
| close_command_expr={"panda_finger_joint1": 0.015}, | ||
| close_command_expr={"panda_finger_joint1": 0.01}, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔵 Suggestion · Implementation — Shared IK gripper close width changed
|
||
| ) | ||
|
|
||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Warning · Implementation — Soft-beam PhysX friction tuning silently dropped
FrankaClothEnvCfg.__post_init__replacessim.physicswith the cloth module's ownPhysicsCfg, so this preset is consumed only by the already-releasedIsaac-Lift-Soft-Franka(-Camera)tasks. Clearingfriction_offset_threshold=0.005andfriction_correlation_distance=0.01reverts that task's PhysX contact tuning to defaults, is not needed for cloth PhysX support, and is not covered by theAdded-only changelog fragment. Restore the values or record the change underChanged.