Drop the dead importers token from the kit-less image - #7062
Draft
hujc7 wants to merge 1 commit into
Draft
Conversation
`--install ... ,importers` names a token the install CLI does not define, so every kit-less image build logs "Unknown install token 'importers'. Skipping" and the selector reads as if it installs something. Nothing else references it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Summary
docker/Dockerfile.kitlesspasses--install ... ,importers, but the install CLI defines noimporterstoken, so every kit-less image build logsUnknown install token 'importers'. Valid values: ... Skippingand carries on.grep -rn importers docker/ .github/returns only prose.2. Verification
importersin[project.optional-dependencies]importersinVALID_EXTRA_FEATURES(install.py)newton,rl,ov,visualizerVALID_EXTRA_FEATURES3. Notes
Spotted by @StafaH while reviewing #6935 ("I don't see importers anywhere in the PR for isaaclab.sh -i, is this correct?"). The condition predates that PR, so it is split out to stay independent of it.