-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[Workflow] Default classic core tasks to Newton #7066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 5 commits
f0eaf24
c3329cb
742fbf2
f416d9e
543ee34
0fddcfe
c0e5f45
6c98c4f
1e76a29
20955dc
3e5b9be
9ad93dd
ac93fbd
d1f4ef9
d0a8017
e8cf939
1a7adb4
07000a9
5ffde71
46d2aac
48065ef
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| Changed | ||
| ^^^^^^^ | ||
|
|
||
| * **Breaking:** Changed the Cartpole task family and the default renderer preset | ||
| to Newton MJWarp and the Newton renderer. Pass explicit physics and renderer | ||
| presets to retain an Isaac Sim PhysX configuration. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,11 +22,11 @@ class _AutoRtxRendererCfg(RendererCfg): | |
|
|
||
| @configclass | ||
| class MultiBackendRendererCfg(PresetCfg): | ||
| default: IsaacRtxRendererCfg = IsaacRtxRendererCfg() | ||
| default: NewtonWarpRendererCfg = NewtonWarpRendererCfg() | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This changes the renderer default for every task that uses
Please keep the shared default unchanged and introduce a Cartpole-specific renderer preset/default, or migrate and explicitly pin every affected consumer while providing the missing Newton renderer support. The current shared change is a runtime regression outside the PR title scope.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed in 6c98c4f: MultiBackendRendererCfg retains its Isaac RTX default. Newton renderer defaults are now scoped to the Cartpole camera configurations, preserving contrib, Mimic, XR, and Shadow Hand behavior. |
||
| rtx: _AutoRtxRendererCfg = _AutoRtxRendererCfg() | ||
| newton_renderer: NewtonWarpRendererCfg = NewtonWarpRendererCfg() | ||
| ovrtx: OVRTXRendererCfg = OVRTXRendererCfg() | ||
| isaacsim_rtx = default | ||
| isaacsim_rtx: IsaacRtxRendererCfg = IsaacRtxRendererCfg() | ||
|
|
||
|
|
||
| def set_isaac_rtx_global_settings(renderer_cfg: Any, **settings: Any) -> None: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,16 +22,18 @@ | |
| from env_test_utils import _run_environments, setup_environment # isort: skip | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("physics_preset_name", ["newton_mjwarp", "physx", "isaacsim_physx"]) | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This matrix does not guarantee the backend named in the test ID. Global preset resolution falls back to Please generate only supported
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed in 6c98c4f: the matrix now includes only task/backend pairs whose raw config explicitly exposes the requested physics preset. Play filtering remains removed because the current registry has no Play task variants. |
||
| @pytest.mark.parametrize("num_envs, device", [(2, "cuda"), (1, "cuda")]) | ||
| @pytest.mark.parametrize( | ||
| "task_name", | ||
| setup_environment( | ||
| include_play=False, | ||
| multi_agent=False, | ||
| tier="core", | ||
| ), | ||
| ) | ||
| @pytest.mark.isaacsim_ci | ||
| def test_environments(task_name, num_envs, device): | ||
| def test_environments(task_name, physics_preset_name, num_envs, device): | ||
| # run environments without stage in memory | ||
| _run_environments(task_name, device, num_envs, create_stage_in_memory=False) | ||
| _run_environments( | ||
| task_name, device, num_envs, create_stage_in_memory=False, physics_preset_name=physics_preset_name | ||
| ) | ||
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This entry explicitly marks both default changes as breaking, but I could not find a prior deprecation for either the Cartpole backend default or the shared renderer default. Please reconcile this with the repository policy that breaking changes require a deprecation first, or document why these default changes are exempt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an intentional 3.0 breaking default change. The fragment now accurately scopes it to Cartpole and provides the explicit-preset migration path; we are not adding deprecation artifacts for this release.