-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[Validation] Test OVRTX 0.4.1 with OVPhysX 0.5.10 #7143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
nvsekkin
wants to merge
7
commits into
isaac-sim:develop
from
nvsekkin:esekkin/ovrtx-041-wiht-ovphysx-0510
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1e46d6a
Update OvPhysX to 0.5.10
AntoineRichard 0310d75
feat: Update OVRTX runtime to 0.4.1
nvsekkin 081abd2
fix: Complete OVRTX 0.4.1 integration
nvsekkin 8855ffc
fix: Pin the OVRTX runtime build
nvsekkin a7c8354
test: Merge OVPhysX 0.5.10 for compatibility validation
nvsekkin 745d5e9
test: Run OVStage kitless validation on pull requests
nvsekkin cb46071
style: Align OVStage validation comment
nvsekkin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Test-only: verified that the public OVRTX package resolves through the public PyPI index. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| Only the pinned OvPhysX version asserted by ``test_version_single_source_matches_literal_pins`` | ||
| changed; there is no user-visible behaviour change in ``isaaclab``. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| Changed | ||
| ^^^^^^^ | ||
|
|
||
| * Updated the optional OVRTX runtime dependency to the public ``ovrtx==0.4.1.364340`` package and | ||
| enabled synchronous texture streaming for deterministic material readiness. Reinstall the OVRTX | ||
| extra with ``uv sync --extra ovrtx`` to use the supported runtime. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| Changed | ||
| ^^^^^^^ | ||
|
|
||
| * Updated OvPhysX to 0.5.10 and the OpenUSD stage bindings to ovstage 0.1.1.355824. | ||
| The two move together: OvPhysX 0.5.10 requires that exact ovstage build, so bumping | ||
| it alone leaves the environment unresolvable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Warning · Implementation — OVStage rendering job now runs on every PR
The removed
github.event_name != 'pull_request'guard kept this 120-minute self-hosted GPU job post-merge only, and the added comment labels it a "Validation branch" change to exercise the new pins. As written, every pull request permanently gains a second full kitless rendering matrix, and thetest-node-ids-file/test-node-ids-keyinputs still apply only onpush, so PR runs execute the uncurated matrix. Restore the post-merge condition before merging.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the intention - test pr