[Workflow/Docs] Consolidate multi-GPU documentation - #7182
Conversation
There was a problem hiding this comment.
Isaac Lab Review Bot
The CLI rename preserves the deprecated underscore alias and updates documentation and tests, but the OSMO workflow now invokes the new command inside a pinned container image that predates the rename.
- Design and architecture: The alias-based migration preserves compatibility for updated checkouts. However, the OSMO workflow executes the CLI supplied by its container rather than the current checkout, so changing the template command independently of the pinned image creates a producer/consumer version mismatch.
- API: The local CLI supports both
train-multigpuand the warning-emittingtrain_multigpualias. The pinnednvcr.io/nvidia/isaac-lab:3.0.0-beta2image does not include this newly introduced canonical spelling, making the updated OSMO default incompatible with that image. - Implementation: The CLI dispatch and alias forwarding are covered by focused tests. The OSMO multi-GPU path at line 64 should retain
train_multigpuuntil its default container image includes the renamed command, or the image and command must be updated together.
Minor fixes needed. Posted 1 actionable finding inline.
Automated review; human maintainers own approval decisions.
Greptile SummaryThe PR consolidates multi-GPU documentation around the canonical underscore command spelling while preserving deprecated hyphenated benchmark aliases.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
CLI[Benchmark CLI] --> Canonical{Command spelling}
Canonical -->|workflow_multigpu| Launcher[Multi-GPU launcher]
Canonical -->|workflow-multigpu| Warning[Deprecation warning]
Warning --> Launcher
Launcher --> Workers[One worker per GPU]
Reviews (2): Last reviewed commit: "Apply suggestion from @AntoineRichard" | Re-trigger Greptile |
| .. note:: | ||
|
|
||
| The template uses the deprecated ``train_multigpu`` spelling because its default | ||
| ``3.0.0-beta2`` container image predates the rename. Custom images built from current source can | ||
| use ``train-multigpu``. | ||
|
|
There was a problem hiding this comment.
Do we need to support this? I don't know if for this in particular applying a deprecation cycle on beta 2 makes sense.
| "train": train, | ||
| "train_multigpu": train_multigpu, | ||
| "train-multigpu": train_multigpu, | ||
| "train_multigpu": _train_multigpu_deprecated, |
There was a problem hiding this comment.
should we remove this?
…u-docs # Conflicts: # docs/source/refs/reference_architecture/index.rst
Co-authored-by: Antoine RICHARD <antoiner@nvidia.com> Signed-off-by: Mustafa H <34825877+StafaH@users.noreply.github.com>
|
run-ci |
…ommand-rename # Conflicts: # docs/source/features/multi_gpu.rst
…82-remove-command-rename
|
run-co |
|
run-ci |
|
run-ci |
## Description Backports #7182 to `release/3.0.0` by cherry-picking merged commit `c1b0cbd25c488d3c30d070636f8b402e9cbcdc17`. This consolidates the multi-GPU guide, standardizes benchmark workflows on `startup_multigpu`, `runtime_multigpu`, and `training_multigpu`, and retains the hyphenated forms as deprecated compatibility aliases. No new dependencies. ## Type of change - Documentation update - Non-breaking benchmark CLI change with deprecated compatibility aliases ## Release backport Not applicable; this PR targets the active release branch. ## Validation - [x] Focused benchmark tests: 22 passed - [x] `uv run isaaclab -f` equivalent with `ISAACLAB_CHANGELOG_BASE_REF=release/3.0.0`: passed - [x] Warning-as-error docs build: passed - [x] Backport patch ID matches merged #7182 The host was macOS, while the project lock and `ovstage` wheel support Linux/Windows. Validation therefore used a temporary uv-managed Python 3.12 environment; Sphinx autodoc mocked only the unavailable Linux `ovstage` module. ## Checklist - [x] I have read and understood the contribution guidelines - [x] I have run the pre-commit checks - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove the canonical and compatibility command dispatch - [x] I have included the original changelog fragment for the touched package - [x] The original author already exists in `CONTRIBUTORS.md` Signed-off-by: Mustafa H <34825877+StafaH@users.noreply.github.com> Co-authored-by: Mustafa H <34825877+StafaH@users.noreply.github.com> Co-authored-by: Antoine RICHARD <antoiner@nvidia.com>
Description
Reworks the multi-GPU guide around a task-first flow modeled after the quickstart and installation pages while retaining the established
train_multigpucommand spelling.train_multigpustartup_multigpu,runtime_multigpu, andtraining_multigpuNo new dependencies.
Type of change
Release backport
developScreenshots
Not applicable.
Validation
uv run --extra test pytest -q source/isaaclab/test/benchmark/test_multigpu_launcher.py source/isaaclab/test/benchmark/test_distributed.py(22 passed)uv run isaaclab -fuv run --no-project python tools/skills/cli.py check(21 skills validated)uv run --isolated --extra test -- make -C docs current-docs(warning-free)Checklist
CONTRIBUTORS.md