-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Restore Franka cloth motion-vector regression coverage #7195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 6 commits
b8ddbe9
295d649
f002c46
40013e0
77d3b45
63b507b
40ba5ac
14454b1
9c9d0be
db6d4c2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Test-only: captured Franka cloth motion vectors during a controlled fall. |
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. new golden shows the motion vector in frame 3 - will be addressed in ovrtx 0.5.0 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1791,6 +1791,9 @@ def _configure_franka_camera_test_env_cfg(env_cfg: Any, data_type: str) -> None: | |
| """Apply deterministic golden rendering test overrides to a resolved Franka camera config.""" | ||
| _apply_franka_camera_golden_scene_overrides(env_cfg, data_type) | ||
| env_cfg.commands.deformable_pose.debug_vis = False | ||
| if data_type == "motion_vectors": | ||
| initial_pos = env_cfg.scene.deformable.init_state.pos | ||
| env_cfg.scene.deformable.init_state.pos = (initial_pos[0], initial_pos[1], initial_pos[2] + 0.01) | ||
|
nvsekkin marked this conversation as resolved.
Outdated
nvsekkin marked this conversation as resolved.
Outdated
|
||
| env_cfg.events.reset_deformable.params["position_range"] = { | ||
| "x": (0.0, 0.0), | ||
| "y": (0.0, 0.0), | ||
|
|
@@ -1804,7 +1807,8 @@ def rendering_test_franka_cloth( | |
| data_type: str, | ||
| comparison_scores: list[dict], | ||
| ) -> None: | ||
| _skip_if_newton_motion_vectors(physics_backend, data_type) | ||
| if renderer != "ovrtx_renderer": | ||
| _skip_if_newton_motion_vectors(physics_backend, data_type) | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the motion vector for deformable is still observed missing in the isaac rtx path |
||
|
|
||
| if renderer == "ovrtx_renderer" and data_type == "instance_segmentation": | ||
| pytest.skip("instance_segmentation crashes with the OVRTX renderer on franka_cloth (NVBUG#6463802).") | ||
|
|
@@ -1831,11 +1835,12 @@ def rendering_test_franka_cloth( | |
|
|
||
| maybe_save_stage(test_name, physics_backend, renderer, data_type) | ||
|
|
||
| # We step only once to let the cloth fall uniformly on the gravity but not collide with the cube on the table. | ||
| # This is to limit the inconsistent nodal poses and pixels from run to run due to solver scheduling and | ||
| # numerical precision. | ||
| # Advance the cloth before capturing camera output. | ||
| zero_actions = torch.zeros(env.num_envs, env.action_manager.total_action_dim, device=env.device) | ||
| env.step(zero_actions) | ||
| # TODO: Remove the extra step when NVBug 6565960 is fixed. | ||
| if data_type == "motion_vectors": | ||
|
nvsekkin marked this conversation as resolved.
Outdated
|
||
| env.step(zero_actions) | ||
|
|
||
| camera = env.scene.sensors["base_camera"] | ||
| camera_outputs = camera.data.output | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.