-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[Bump] Bump Newton to 1.6.0rc1 for newton#4017 #7445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 10 commits
abfa2b8
e53d2fc
cd565d7
08c6b79
83d8ca4
acd81c8
68f4090
80485f5
c5f8174
92868b6
76ca82a
bd05cad
b184335
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| CI-only fix; no user-visible change. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| CI-only fix; no user-visible change. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| Changed | ||
| ^^^^^^^ | ||
|
|
||
| * Changed the pinned Newton version from ``1.5.1`` to ``1.6.0rc1``, the first release carrying | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 Warning · Api — Release note misstates the previous Newton pin This diff replaces |
||
| `newton#4017 <https://github.com/newton-physics/newton/pull/4017>`_, which makes | ||
| ``ArticulationView`` generic over custom frequencies. Reading a MuJoCo actuator attribute such | ||
| as ``mujoco.actuator_trntype`` through an articulation view previously raised *"has custom | ||
| frequency 'mujoco:actuator' which is not supported by ArticulationView"*. | ||
| * Changed ``warp-lang`` from ``1.16.0`` to ``1.17.0`` and ``mujoco``/``mujoco-warp`` from | ||
| ``3.11.0`` to ``3.12.0``, which Newton ``1.6.0rc1`` requires. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| Test-only change: the P-ADMM round-trip test now builds a solver combination the | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔵 Suggestion · Implementation — Fragment describes a change absent from diff The only |
||
| pinned Newton accepts. No user-visible behavior change. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| Fixed | ||
| ^^^^^ | ||
|
|
||
| * Fixed ``test_manipulation_env_determinism`` asserting bit-reproducible rewards without requesting | ||
| a determinism guarantee. Newton defaults to ``wp.DeterministicMode.NOT_GUARANTEED``, under which | ||
| Warp's atomics may accumulate in any order, so the test failed intermittently depending on GPU | ||
| scheduling. It now passes ``deterministic_mode="run_to_run"``, as the Newton cartpole cases | ||
| already did. |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔵 Suggestion · Implementation — Unrelated changelog fragments committed
This fragment and
jichuanh-kitless-isaac-sim-symlink.skipdescribe a deps-invariants fix and a kit-less Isaac Sim symlink fix, neither of which appears in this diff; theisaaclabchange here is already covered byjichuanh-newton-pin-4017.minor.rst. Drop both so the commit stays focused andchangelog.ddoes not accumulate fragments for unshipped work.