-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[Bump] Bump Newton to 1.6.0rc1 for newton#4017 #7445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kellyguo11
merged 13 commits into
isaac-sim:develop
from
hujc7:jichuanh/newton-pin-4017-uvlock
Sep 5, 2026
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
abfa2b8
Give the P-ADMM round-trip test a solver combination Newton accepts
hujc7 e53d2fc
Repoint extras-qualified prebundle mirrors alongside the flat package
hujc7 cd565d7
Bump Newton to 1.6.0rc1 for newton#4017
hujc7 08c6b79
Follow Newton's Drive actuator class names in the tests
hujc7 83d8ca4
Request a determinism guarantee in the manipulation determinism test
hujc7 acd81c8
Load the base image before asserting its invariants
hujc7 68f4090
Do not link a missing Isaac Sim in the kit-less test lane
hujc7 80485f5
Ask for determinism only on the Newton-backed manipulation task
hujc7 c5f8174
Merge develop; drop the CI fixes it landed upstream
hujc7 92868b6
Merge develop; keep the 1.6.0rc1 pin and drop superseded work
hujc7 76ca82a
Clean up changelog fragments and clarify the determinism mode comment
hujc7 bd05cad
Assert the pinned Newton release in the wheel install test
hujc7 b184335
Pin Newton in [project].dependencies for wheel installs
hujc7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
source/isaaclab/changelog.d/jichuanh-newton-pin-4017.minor.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| Changed | ||
| ^^^^^^^ | ||
|
|
||
| * Changed the pinned Newton version from ``1.5.1`` to ``1.6.0rc1``, the first release carrying | ||
| `newton#4017 <https://github.com/newton-physics/newton/pull/4017>`_, which makes | ||
| ``ArticulationView`` generic over custom frequencies. Reading a MuJoCo actuator attribute such | ||
| as ``mujoco.actuator_trntype`` through an articulation view previously raised *"has custom | ||
| frequency 'mujoco:actuator' which is not supported by ArticulationView"*. | ||
| * Changed ``warp-lang`` from ``1.16.0`` to ``1.17.0`` and ``mujoco``/``mujoco-warp`` from | ||
| ``3.11.0`` to ``3.12.0``, which Newton ``1.6.0rc1`` requires. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
source/isaaclab_newton/changelog.d/jichuanh-newton-actuator-rename-test.skip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| Test-only change: the actuator tests now assert Newton's new drive class names | ||
| (``DrivePD``, ``DriveNeuralMLP``, ``DriveNeuralLSTM``). Newton 1.6.0rc1 still exports the | ||
| old ``Controller*`` aliases, so there is no user-visible behavior change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 8 additions & 0 deletions
8
source/isaaclab_tasks/changelog.d/jichuanh-manipulation-determinism-mode.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| Fixed | ||
| ^^^^^ | ||
|
|
||
| * Fixed ``test_manipulation_env_determinism`` asserting bit-reproducible rewards without requesting | ||
| a determinism guarantee. Newton defaults to ``wp.DeterministicMode.NOT_GUARANTEED``, under which | ||
| Warp's atomics may accumulate in any order, so the test failed intermittently depending on GPU | ||
| scheduling. It now passes ``deterministic_mode="run_to_run"``, as the Newton cartpole cases | ||
| already did. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Warning · Api — Release note misstates the previous Newton pin
This diff replaces
newton[sim] @ git+...@24bd8635..., whichuv.lockrecorded as version1.6.0.dev0, not1.5.1. The published note therefore misidentifies both the prior dependency and who was affected by theArticulationViewcustom-frequency error. Restate it as moving from the pinned Newton git revision to the1.6.0rc1PyPI release, and consider noting theControllerPDtoDrivePDconstruction rename that this bump makes user-visible.