Update China storage profile to Isaac Sim 6.1 - #7467
Conversation
There was a problem hiding this comment.
Isaac Lab Review Bot
The PR consistently advances the China storage profile from Isaac Sim 6.0 to 6.1 across the asset-root constant, availability-manifest documentation, and package changelog. No candidate findings were submitted or supported by the patch.
- Design and architecture: The release remains centralized in
_ISAAC_SIM_ASSET_RELEASEand feeds only the China profile’s versionedasset_root. Profile selection, endpoint/CDN routing, and asset-loading flow are unchanged. - API: No public symbols, environment variables, or precedence rules change. The user-visible compatibility surface is the China profile’s resolved asset-root suffix, which now targets 6.1 and is documented in the matching changelog fragment.
- Implementation: The updated constant produces the intended
/Assets/Isaac/6.1root, and the documentation points to the corresponding 6.1 availability manifest. The remaining non-blocking dependency is external mirror completeness, which users can evaluate through the documented manifest.
No blocking issues. No inline issue met the actionable-evidence threshold; the assessment above records the review feedback.
Automated review; human maintainers own approval decisions.
Greptile SummaryUpdates the China storage profile from the Isaac Sim 6.0 asset root to 6.1 and aligns the installation documentation and changelog with that release.
Confidence Score: 5/5The PR appears safe to merge, with the runtime profile, documentation, and changelog consistently targeting the validated Isaac Sim 6.1 China asset set. The changed release constant is confined to the explicitly selected China profile, aligns with existing 6.1 application configuration, and is accompanied by matching documentation and availability validation. Important Files Changed
Reviews (1): Last reviewed commit: "Update China storage profile to Isaac Si..." | Re-trigger Greptile |
AntoineRichard
left a comment
There was a problem hiding this comment.
Thanks @sheikh-nv!
|
run-ci |
# Description Backports the following merged `develop` PRs to `release/3.0.0`: - #7220 — prune unused Docker volumes on package-test runners - #7169 — cache the resolved OVRTX Warp device - #6889 — move the OVPhysX collider cache out of the Python interpreter directory - #7345 — document the registered XR camera PiP tasks - #7050 — update and reorganize the LEAPP documentation - #7473 — register external RSL-RL tasks before agent discovery - #7467 — update the China storage profile to Isaac Sim 6.1 - #7385 — accept legal float scale values when seeding Fabric frame views from USD - #7517 — use lazy exports in `isaaclab_rl` The duplicate #7517 in the original request is included once. Seven source commits replayed cleanly. Two required release-specific reconciliation: - #7169 retains the release branch's mapped OVRTX write path, which was removed separately on `develop`, while resolving and caching one Warp device for render-product IDs, mappings, and CUDA streams. - #7050 preserves the #7494 export-backend clarification that is already present on the release branch while applying the broader LEAPP documentation overhaul. No new dependencies are added. ## Type of change - Bug fix (non-breaking change which fixes an issue) - Performance improvement - Documentation update - CI/infrastructure update ## Release backport - [ ] <!-- backport-active-release --> This PR already targets the active release branch; do not backport it again. ## Validation - `uv run --no-project --with pytest python -m pytest -q .github/actions/run-package-tests/test_cleanup_docker_storage.py` — 10 passed - Nine isolated `isaaclab_rl` namespace/lazy-import regression cases passed - Resolved-device OVRTX mapping behavior check passed with Warp 1.16.0 - `uv run --no-project python -m compileall -q` on all changed Python modules and tests - `uv run --no-project python tools/changelog/cli.py check` against the exact `upstream/release/3.0.0` base - `pre-commit==4.6.2 run --all-files` passed all available hooks - `git diff --check upstream/release/3.0.0..HEAD` The full project test environment and documentation build cannot resolve on this macOS/arm64 host because the release lockfile supports Linux and Windows only. The Git LFS hook was also unavailable because `git-lfs` is not installed; none of the changed paths are LFS-tracked. Linux CI remains authoritative for simulator, OVRTX, Fabric, and full documentation validation. ## Checklist - [x] I have read and understood the contribution guidelines - [x] I have run the available formatting and static checks - [x] I have included the corresponding documentation changes - [x] Each touched source package includes its original changelog fragment - [x] Every backported commit records its source commit with `cherry picked from commit` - [x] The original contributors are preserved as commit authors --------- Signed-off-by: Zeng Qingcheng <60593302+NeoZng@users.noreply.github.com> Co-authored-by: myurasov-nv <168484206+myurasov-nv@users.noreply.github.com> Co-authored-by: Peter Verswyvelen <pverswyvelen@nvidia.com> Co-authored-by: pv-nvidia <197907000+pv-nvidia@users.noreply.github.com> Co-authored-by: hujc <jichuanh@nvidia.com> Co-authored-by: hougantc-nvda <127865892+hougantc-nvda@users.noreply.github.com> Co-authored-by: Frank Lai NV <frlai@nvidia.com> Co-authored-by: peterd-NV <peterd@nvidia.com> Co-authored-by: Sheikh Dawood <7774242+sheikh-nv@users.noreply.github.com> Co-authored-by: Zeng Qingcheng <60593302+NeoZng@users.noreply.github.com> Co-authored-by: Antoine RICHARD <antoiner@nvidia.com> Co-authored-by: Mustafa H <34825877+StafaH@users.noreply.github.com>
# Description <!-- Thank you for your interest in sending a pull request. Please make sure to check the contribution guidelines. Link: https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html 💡 Please try to keep PRs small and focused. Large PRs are harder to review and merge. --> Aligns Isaac Lab with Isaac Sim's Asset Region Profiles terminology and configuration. The installation guide now has a top-level **Asset Region Profiles** section immediately after **Asset caching**, with `us` and `china` selection, precedence, switchback, kitless initialization, and manifest guidance. The implementation uses `ISAACSIM_ASSET_REGION_PROFILE`, adds an explicit `us` profile and `configure_asset_region_profile()`, and replaces the development-only `ISAACSIM_STORAGE_PROFILE` selector. The installation skill and focused tests are updated with the same behavior. This is a follow-up to #7467. No additional dependencies are required. <!-- As a practice, it is recommended to open an issue to have discussions on the proposed pull request. This makes it easier for the community to keep track of what is being developed or added, and if a given feature is demanded by more than one party. --> ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Documentation update ## Release backport - [x] <!-- backport-active-release --> Backport this pull request to the active release branch after it merges into `develop` ## Screenshots Rendered installation documentation was verified locally. <!-- Example: | Before | After | | ------ | ----- | | _gif/png before_ | _gif/png after_ | To upload images to a PR -- simply drag and drop an image while in edit mode and it should upload the image directly. You can then paste the source into the above before/after sections. --> ## Checklist Docker and GPU tests run on demand. Push the commits you want tested, then comment `run-ci` on the pull request. - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have added a changelog fragment under `source/<pkg>/changelog.d/` for every touched package (do **not** edit `CHANGELOG.rst` or bump `extension.toml` — CI handles that) - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task --> ## Validation - `uv run isaaclab -f` passed. - Python compilation, changelog validation, and diff checks passed. - All 21 repository skill checks passed. - Focused no-network checks passed for the new selector and profile resolution. - Full tests and documentation builds are covered by the PR checks.
# Description <!-- Thank you for your interest in sending a pull request. Please make sure to check the contribution guidelines. Link: https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html 💡 Please try to keep PRs small and focused. Large PRs are harder to review and merge. --> Aligns Isaac Lab with Isaac Sim's Asset Region Profiles terminology and configuration. The installation guide now has a top-level **Asset Region Profiles** section immediately after **Asset caching**, with `us` and `china` selection, precedence, switchback, kitless initialization, and manifest guidance. The implementation uses `ISAACSIM_ASSET_REGION_PROFILE`, adds an explicit `us` profile and `configure_asset_region_profile()`, and replaces the development-only `ISAACSIM_STORAGE_PROFILE` selector. The installation skill and focused tests are updated with the same behavior. This is a follow-up to #7467. No additional dependencies are required. <!-- As a practice, it is recommended to open an issue to have discussions on the proposed pull request. This makes it easier for the community to keep track of what is being developed or added, and if a given feature is demanded by more than one party. --> ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) - Documentation update ## Release backport - [x] <!-- backport-active-release --> Backport this pull request to the active release branch after it merges into `develop` ## Screenshots Rendered installation documentation was verified locally. <!-- Example: | Before | After | | ------ | ----- | | _gif/png before_ | _gif/png after_ | To upload images to a PR -- simply drag and drop an image while in edit mode and it should upload the image directly. You can then paste the source into the above before/after sections. --> ## Checklist Docker and GPU tests run on demand. Push the commits you want tested, then comment `run-ci` on the pull request. - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have added a changelog fragment under `source/<pkg>/changelog.d/` for every touched package (do **not** edit `CHANGELOG.rst` or bump `extension.toml` — CI handles that) - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task --> ## Validation - `uv run isaaclab -f` passed. - Python compilation, changelog validation, and diff checks passed. - All 21 repository skill checks passed. - Focused no-network checks passed for the new selector and profile resolution. - Full tests and documentation builds are covered by the PR checks. (cherry picked from commit 84a6d9c)
Description
Updates the China storage profile asset root and public availability manifest from Isaac Sim 6.0 to 6.1. This does not change profile routing or asset-loading behavior.
Validation:
No additional dependencies are required.
Type of change
Release backport
developScreenshots
Not applicable.
Checklist
Docker and GPU tests run on demand. Push the commits you want tested, then
comment
run-cion the pull request.pre-commitchecks with./isaaclab.sh --formatsource/<pkg>/changelog.d/for every touched packageCONTRIBUTORS.mdor my name already exists there