[Fix] Publish and fetch the checkpoints a task's components declare - #7485
Draft
hujc7 wants to merge 4 commits into
Draft
[Fix] Publish and fetch the checkpoints a task's components declare#7485hujc7 wants to merge 4 commits into
hujc7 wants to merge 4 commits into
Conversation
Collaborator
Author
|
run-ci |
8 tasks
Collaborator
Author
|
run-ci |
Collaborator
Author
|
run-ci |
play --checkpoint pretrained crashed on the Shadow Hand camera tasks: the vision CNN the policy needs was never published beside it, and nothing in the tooling knew the file existed. A component now declares what it writes with a Checkpoint on its own config. The tooling walks the resolved environment config to find every declaration, so a task declares nothing, and publishes each file beside the policy as <policy stem>_<name><extension>. The download path fetches them with the policy.
hujc7
force-pushed
the
jichuanh/pretrained-feature-extractor-ckpt
branch
from
September 4, 2026 04:22
8a871d9 to
eda9b46
Compare
Collaborator
Author
|
run-ci |
Collaborator
Author
|
run-ci |
"Auxiliary" ranked these files below the policy and did not generalise: any component can declare a run artifact, and the policy is not special among them. The discovery and path helpers, their parameter, and the collect locals now say declared.
hujc7
force-pushed
the
jichuanh/pretrained-feature-extractor-ckpt
branch
from
September 4, 2026 07:59
17433c7 to
b87603e
Compare
Collaborator
Author
|
run-ci |
…ned-feature-extractor-ckpt # Conflicts: # source/isaaclab_rl/isaaclab_rl/utils/pretrained_checkpoint.py # source/isaaclab_rl/test/test_pretrained_checkpoint.py
Collaborator
Author
|
run-ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
play --checkpoint pretrainedcrashed on the Shadow Hand camera tasks: the vision CNN the policyneeds was never published beside it, and nothing in the tooling knew the file existed. This PR adds
the smallest mechanism that fixes it — a component declares what it writes, and the tooling
publishes and fetches it with the policy.
The refactor that this mechanism invites is deliberately not here; it is stacked in
#7509 — Replace the pretrained checkpoint functions with CheckpointBundle.
Description
1. Declaring a checkpoint
A component declares what it writes on its own config:
get_declared_checkpointswalks the resolved environment config to find every declaration, so atask declares nothing and the component that writes the file owns its name. Each file is published
beside the policy as
<policy stem>_<name><extension>and fetched with it.Checkpoint.resolvehands the component its local file, so no component needs to know the naming convention.
Checkpointalso covers weights that already exist (url=): a frozen encoder is fetched but neverpublished by the checkpoint tooling.
2. Published checkpoints
Both companion pairs are trained and published, so the fix has something to fetch:
Isaac-Reorient-Cube-Shadow-CameraIsaac-Reorient-Cube-Shadow-Camera-DirectEach is a policy
.ptplus its_feature_extractor.pth.3. Verification
test_pretrained_checkpoint.py,test_checkpoints.py,test_train_and_publish_checkpoints.py,test_shadow_hand_camera_presets.pyandtest_pretrained_checkpoint_lookup.py.isaaclab -fclean.urlweights,and that a published file keeps the extension the component declared.
Type of change
Release backport
developChecklist
pre-commitchecks with./isaaclab.sh --formatsource/<pkg>/changelog.d/for every touched packageCONTRIBUTORS.mdor my name already exists there