[CI] Link _isaac_sim only where Kit is installed in the test container - #7543
Draft
hujc7 wants to merge 1 commit into
Draft
[CI] Link _isaac_sim only where Kit is installed in the test container#7543hujc7 wants to merge 1 commit into
hujc7 wants to merge 1 commit into
Conversation
run_tests.sh bind-mounts writable runtime storage under /isaac-sim into every image, so that directory exists in the kit-less image too, and the unconditional _isaac_sim link then reads as a downloaded Isaac Sim. isaaclab.sh (isaac-sim#7466) refuses that next to the image's VIRTUAL_ENV, so the kit-less multi-GPU smoke exits before pytest on every PR into this branch. Link only where Kit's python.sh exists.
Collaborator
Author
|
@greptileai review |
Contributor
Greptile SummaryThe PR prevents kit-less test containers from creating an
Confidence Score: 5/5The PR appears safe to merge with no actionable defects identified. The conditional preserves the link in supported Kit images and omits it in kit-less images, avoiding the virtual-environment conflict while retaining the expected simulator discovery path. Important Files Changed
Reviews (1): Last reviewed commit: "Link _isaac_sim only where Kit is instal..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Multi-GPU training smoke (kit-less)fails on every PR intorelease/3.0.0, exiting before pytestruns. Two lines in the shared test-container script fix it.
Description
1. Cause
run_tests.shbind-mounts nine writable runtime directories under/isaac-sim/…into everycontainer, so
/isaac-simexists as a directory in the kit-less image as well — which ships no Kit.The container script then plants the link unconditionally:
isaaclab.shtreats an_isaac_simdirectory without a.isaaclab_source_buildmarker as adownloaded Isaac Sim and refuses to combine it with an active virtual environment (#7466, on this
branch as 69d5d1f).
Dockerfile.kitlesssetsVIRTUAL_ENV=/opt/isaaclab-venv(#6355), so everykit-less run stops at:
2. Change
Plant the link only where Kit actually lives at that path. Kit images are unaffected — they have
/isaac-sim/python.shand get the link exactly as before; the kit-less image resolves itsinterpreter through
VIRTUAL_ENV, as it did before #7466.The same script serves ~29 CI jobs through
run-testsandrun-package-tests, all but one of whichpass a Kit image, so testing the container rather than threading a "kit-less" flag through every
caller keeps the fix to one place.
3. Verification
docker/test/test_container_profiles.pyfails on the unmodified script(
AssertionError: ['ln -s /isaac-sim _isaac_sim']) and passes with it. 14 pass in that file.bash -non the script; pre-commit on both files.developturned the job green end to end:8 passed, 7 deselected in 790.74s, with zero occurrences of the venv error in the job log.4. Relationship to the
developfixThe develop-side PR pairs this with a second, unrelated fix for the
Build Base Docker Imagejob,which fails there because #7405 added an image-invariants step that a deps-cache hit cannot satisfy.
#7405 is not on this branch — its
Dockerfile.basestill installs with_isaac_sim/python.sh -m pip, there is no invariants step, and its author left the backport boxunticked. That half would be dead config here, so this PR carries only the part that applies.
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatCONTRIBUTORS.mdor my name already exists there