test: Add all-environment perspective golden - #7550
Conversation
NVBUG 6632117
Greptile SummaryAdds a PhysX/Kit visual-regression test that captures four spatially separated Cartpole environments through one perspective viewport.
Confidence Score: 5/5The test-only change appears safe to merge, with no actionable correctness or security issues identified. The new mode is restricted to the intended Kit viewport path, its environment grid is centered on the configured camera target, and the capture is validated against a committed dedicated golden. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
T[Perspective golden test] --> C[Configure four Cartpole environments]
C --> V[Apply centered Kit camera pose]
V --> R[Capture Kit viewport]
R --> N[Reject empty or flat frame]
N --> G[Compare with cartpole_all_envs golden]
Reviews (1): Last reviewed commit: "test: Cover all scene partitions in pers..." | Re-trigger Greptile |
There was a problem hiding this comment.
Isaac Lab Review Bot
The test-only change adds a focused PhysX + Kit viewport golden for a perspective view containing four spatially separated Cartpole environments. The new scenario is integrated into the existing golden-image harness without altering default test behavior.
- Design and architecture: The implementation reuses the existing Cartpole environment and golden runner, with an opt-in
all_envs_perspectivepath controlling environment count, spacing, and camera pose. Existing tiled-camera behavior remains separate, and incompatible tiled/perspective combinations are explicitly rejected. - API: No public or extension-facing API is changed. The added test-helper parameters are keyword-only and default to
False, preserving existing callers and prior camera/environment configuration. The package also includes the appropriate test-only.skipchangelog fragment. - Implementation: The new test name resolves to the committed
golden_images/cartpole_all_envs/physx-kit-viewport.pngpath. The four-environment configuration and perspective pose are consistently applied to the environment viewer and visualizer configuration, and the capture receives a non-flat-frame check before golden comparison. Coverage is intentionally limited to the requested PhysX + Kit viewport path.
No blocking issues. No inline issue met the actionable-evidence threshold; the assessment above records the review feedback.
Automated review; human maintainers own approval decisions.
|
run-ci |
Description
Adds the perspective-camera visual regression requested as a follow-up to #7053 and [NVBUG 6632117].
Type of change
Release backport
developScreenshot
Validation
uv run isaaclab -fsha256:50d2491d..., Isaac Sim 6.1.0-alpha.72); the repeat comparison passed.Checklist
.skipfragment forisaaclab_visualizers.CONTRIBUTORS.md.