Document cuDNN fallback for deterministic training - #7559
Conversation
There was a problem hiding this comment.
Isaac Lab Review Bot
The change adds a narrowly scoped note describing the optional cuDNN v7 fallback for convolutional determinism. The proposed objection that this environment variable became inert in PyTorch 2.3 is not supported by the supplied repository context or evidence, so it does not warrant maintainer action.
- Design and architecture: The note is appropriately placed in the existing PyTorch determinism discussion and leaves the separate rendering and physics determinism responsibilities unchanged.
- API: No Isaac Lab public API, configuration field, CLI argument, dependency, or compatibility surface is changed; the documentation only mentions an external PyTorch environment variable.
- Implementation: The reStructuredText note is correctly formed and clearly presents the setting as optional and workload-specific. No documentation references, includes, or surrounding instructions are disrupted.
No blocking issues. No inline issue met the actionable-evidence threshold; the assessment above records the review feedback.
Automated review; human maintainers own approval decisions.
Greptile SummaryDocuments an optional environment setting for convolutional training workloads that may improve run-to-run determinism by selecting PyTorch’s cuDNN v7 API path.
Confidence Score: 5/5The documentation-only change appears safe to merge. The new note is narrowly scoped, uses appropriately qualified language, and introduces no accepted correctness, security, or maintainability issue. Important Files Changed
Reviews (1): Last reviewed commit: "Document cuDNN fallback for deterministi..." | Re-trigger Greptile |
|
run-ci |
|
Backported to |
# Description Document `TORCH_CUDNN_V8_API_DISABLED=1` as an optional setting that may improve run-to-run determinism for convolutional training workloads. The note explains that the setting selects PyTorch's cuDNN v7 API instead of cuDNN v8 execution plans. No new dependencies are required. ## Type of change - Documentation update ## Release backport - [x] <!-- backport-active-release --> Backport this pull request to the active release branch after it merges into `develop` ## Screenshots Not applicable. ## Checklist Docker and GPU tests run on demand. Push the commits you want tested, then comment `run-ci` on the pull request. - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `uv run isaaclab -f` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works (not applicable to this documentation-only change) - [x] I have added a changelog fragment under `source/<pkg>/changelog.d/` for every touched package (no source package is touched) - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there ## Validation - `uv run --isolated --extra dev --extra ov -- make -C docs current-docs` - `uv run isaaclab -f` (cherry picked from commit 1a986c9)
Description
Document
TORCH_CUDNN_V8_API_DISABLED=1as an optional setting that may improve run-to-run determinism for convolutional training workloads. The note explains that the setting selects PyTorch's cuDNN v7 API instead of cuDNN v8 execution plans.No new dependencies are required.
Type of change
Release backport
developScreenshots
Not applicable.
Checklist
Docker and GPU tests run on demand. Push the commits you want tested, then
comment
run-cion the pull request.pre-commitchecks withuv run isaaclab -fsource/<pkg>/changelog.d/for every touched package (no source package is touched)CONTRIBUTORS.mdor my name already exists thereValidation
uv run --isolated --extra dev --extra ov -- make -C docs current-docsuv run isaaclab -f