Fix OVRTX clone-plan test import - #7582
Merged
kellyguo11 merged 1 commit intoSep 4, 2026
Merged
Conversation
kellyguo11
requested review from
AntoineRichard,
huidongc,
marcodiiga,
pbarejko and
rilei-nvidia
as code owners
September 4, 2026 18:08
github-actions
Bot
added
bug
8 tasks
![isaaclab-review-bot[bot]](https://avatars.githubusercontent.com/u/157846462?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Isaac Lab Review Bot
The PR adds the missing test-scope torch import and an empty isaaclab_ov .skip changelog fragment. The change is narrowly scoped to repairing test collection/linting without altering runtime behavior.
- Design and architecture: The change affects only a test module’s third-party imports and introduces no package-boundary, dependency-direction, or ownership changes.
- API: No public APIs, configuration defaults, exports, CLI arguments, or documentation surfaces are changed. The
.skipfragment is appropriate for this non-user-visible repair. - Implementation: The
torchimport is placed consistently with the existing third-party imports. Optional OVRTX module detection and pytest skip behavior remain unchanged, and no additional implementation changes are required.
No blocking issues. No inline issue met the actionable-evidence threshold; the assessment above records the review feedback.
Automated review; human maintainers own approval decisions.
Contributor
Greptile SummaryRestores the missing
Confidence Score: 5/5The PR appears safe to merge, with no actionable correctness, security, or compatibility issues identified. The added import resolves existing Torch references, Torch is a required dependency, and module-level Torch imports are already established in sibling OVRTX tests. Important Files Changed
Reviews (1): Last reviewed commit: "Fix OVRTX clone plan test import" | Re-trigger Greptile |
kellyguo11
added a commit
that referenced
this pull request
Sep 4, 2026
# Description Ports #7571 to `develop`. `record_demos.py` removed the `success` termination before environment initialization. The Franka Reach reward configuration references that term through `is_terminated_term`, so reward-manager initialization could not resolve the `success` key. This change: - keeps an inert `success` termination registered while demonstration recording evaluates the original condition manually; - preserves reward-manager references without restoring automatic success resets; - adds a Franka Reach DiffIK startup regression test; - adds the `isaaclab_teleop` changelog fragment. Release-branch counterpart: #7571. The independent `develop` pre-commit baseline failure is split into #7582. This PR's repository-wide pre-commit job depends on that fix landing first. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Release backport - [ ] <!-- backport-active-release --> Backport this pull request to the active release branch after it merges into `develop` An explicit release PR already exists as #7571, so no additional automated backport is requested. ## Screenshots Not applicable. ## Testing - Focused pre-commit checks passed for all three changed files. - `uv run --no-project python tools/changelog/cli.py check --include-worktree` passed. - `git diff --check upstream/develop...HEAD` passed. - The simulator smoke test cannot run locally because the project lockfile does not support the current Apple Silicon macOS host; it is included for Linux CI. - The repository-wide pre-commit baseline is repaired separately by #7582. ## Checklist - [x] I have read and understood the contribution guidelines - [ ] I have run the full repository-wide pre-commit checks (blocked on #7582) - [x] Documentation changes are not required because no public API changed - [x] My changes generate no new warnings - [x] I have added a test that proves the teleop fix is effective - [x] I have added the `isaaclab_teleop` changelog fragment - [x] Maximilian Krause already appears in `CONTRIBUTORS.md` Co-authored-by: Maximilian Krause <maximiliank@nvidia.com>
7 tasks
kellyguo11
added a commit
that referenced
this pull request
Sep 5, 2026
# Description Support both the released OVPhysX 0.5.11 lifecycle API and the OVPhysX 0.6 lifecycle API without changing Isaac Lab's dependency pins. This follows the existing OVRTX 0.4.1/0.5 compatibility pattern: - Detect the installed `ovphysx` distribution version once at import. - Resolve an immutable lifecycle mapping to `warmup_gpu()` / `release()` for OVPhysX 0.5.11 and to `warmup()` / `destroy()` for the OVPhysX 0.6 release line and later, including prerelease and development builds. - Default missing or unparsable metadata to the supported OVPhysX 0.5.11 path. - Keep the public `ov` and `ovphysx` extras pinned to `ovphysx==0.5.11`; OVPhysX 0.6 remains a manual internal-testing overlay. The lifecycle changes preserve existing 0.5.11 cleanup semantics. For OVPhysX 0.6 only, they also retain OVPhysX and OVStage ownership when `destroy()` fails before native teardown so cleanup can be retried; a terminal destroy error releases dead owners. The scope is limited to OVPhysX lifecycle compatibility code, tests, and the `isaaclab_ov` changelog fragment. No actuator changes or dependency updates are included. ## Type of change - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) ## Validation - `uv run --frozen --extra test --extra ovphysx python -m pytest source/isaaclab_ov/test/physics/test_ovphysx_compat.py source/isaaclab_ov/test/physics/test_ovphysx_scene_data_backend.py -q` — 50 passed against the pinned OVPhysX 0.5.11 environment. - The same 50-test suite passed with installed OVPhysX metadata simulated as 0.6.0, including the version-independent OVStage ownership test and version-selected 0.6 lifecycle doubles. - The 0.6 development-build regression fails on the prior PR head and passes with the release-line classifier. - `uv run --extra test --extra ovphysx python -m pytest source/isaaclab_ov/test/assets/test_rigid_object.py::test_warmup_attach_stage_not_called_for_cpu -q` — 1 passed against the real OVPhysX 0.5.11 CPU runtime. - `uv run --frozen --extra test --extra ov python -m pytest source/isaaclab_ov/test/test_ovrtx_clone_plan.py -q` — 17 passed after merging upstream fix #7582. - Changelog fragment validation against current `develop` — passed. - `uv run isaaclab -f` — passed. ## Screenshots Not applicable. ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the pre-commit checks with `uv run isaaclab -f` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective and that the feature works - [x] I have added a changelog fragment under `source/<pkg>/changelog.d/` for every touched package - [x] The contributors already exist in `CONTRIBUTORS.md` --------- Co-authored-by: marcodiiga <1969828+marcodiiga@users.noreply.github.com> Co-authored-by: hujc <jichuanh@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Restores the missing
torchimport intest_ovrtx_clone_plan.py.#7462 converted the existing clone-plan test inputs from Torch tensors to NumPy arrays and removed the then-unused import. #6308 subsequently added a new object-scale test using
torch.onesandtorch.arangewithout restoring the import, causing the repository-wide Ruff pre-commit check to fail withF821 Undefined name torch.This PR contains only the import repair and an
isaaclab_ov.skipchangelog fragment. It unblocks #7579 and other changes based on the currentdevelopbranch.Type of change
Release backport
developNo release backport is required:
release/3.0.0already importstorchin this test.Screenshots
Not applicable.
Testing
uv run --no-project --with pre-commit python -m pre_commit run --all-filesuv run --no-project python tools/changelog/cli.py check --include-worktreegit diff --check upstream/develop...HEADChecklist
F821failureisaaclab_ovchangelog fragmentCONTRIBUTORS.md