Skip to content

Source US asset root from Kit configuration - #7595

Merged
kellyguo11 merged 3 commits into
isaac-sim:developfrom
kellyguo11:codex/pr-7549-production-kit-assets
Sep 5, 2026
Merged

Source US asset root from Kit configuration#7595
kellyguo11 merged 3 commits into
isaac-sim:developfrom
kellyguo11:codex/pr-7549-production-kit-assets

Conversation

@kellyguo11

@kellyguo11 kellyguo11 commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Description

Uses the shipped Kit experience as the single source of truth for the us Asset Region Profile instead of duplicating the production asset URL in Python.

All six shipped .kit experiences now use the production asset root for their default, cloud, and nvidia settings. Focused regression coverage verifies that _US_ASSET_ROOT is initialized by the Kit parser, the us profile keeps its existing resolution path, and every shipped experience remains aligned with the canonical production root.

Follow-up to #7549. No additional dependencies are required.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Release backport

  • Backport this pull request to the active release branch after it merges into develop

Screenshots

Not applicable.

Checklist

Docker and GPU tests run on demand. Push the commits you want tested, then
comment run-ci on the pull request.

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks on the changed files
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a changelog fragment under source/<pkg>/changelog.d/ for every touched package
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

Validation

  • The two focused regression checks fail against the pre-fix Align Isaac Lab with Asset Region Profiles #7549 head and pass with this change.
  • 13 passed, 48 deselected for the asset-root and Kit-experience subset of test_assets.py.
  • All pre-commit hooks passed on the changed files, including Ruff, formatting, codespell, changelog validation, and Git LFS pointer validation.
  • Python compilation and git diff --check passed.
  • Full uv run isaaclab -f was unavailable locally because the project lockfile does not support macOS; the equivalent changed-file pre-commit suite passed.

@kellyguo11
kellyguo11 requested a review from a team September 5, 2026 04:59
@github-actions github-actions Bot added isaac-sim Related to Isaac Sim team isaac-lab Related to Isaac Lab team labels Sep 5, 2026
@greptile-apps

greptile-apps Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR makes the shipped Kit configuration the canonical source for the US asset root.

  • Updates all six shipped Kit experiences from the staging asset endpoint to the production endpoint.
  • Initializes the US storage profile from isaaclab.python.kit.
  • Adds regression coverage for profile resolution and consistency across shipped experiences.
  • Adds a focused changelog fragment.

Confidence Score: 5/5

The PR appears safe to merge, with no actionable correctness, security, or repository-rule violations identified.

The supported source and wheel layouts ship the parsed Kit experience, all shipped experiences now agree on the production root, and the US profile preserves the existing environment-variable precedence and resolution behavior.

Important Files Changed

Filename Overview
source/isaaclab/isaaclab/utils/assets.py Initializes the US profile's asset root from the canonical shipped Kit configuration while preserving environment-variable precedence.
source/isaaclab/test/utils/test_assets.py Adds focused checks for parsed US-profile initialization and production-root consistency across shipped Kit experiences.
apps/isaaclab.python.kit Replaces staging asset-root settings with the canonical production root; the other five shipped experiences receive the same update.
source/isaaclab/changelog.d/codex-pr-7549-production-kit-assets.rst Documents the corrected alignment between the US profile and shipped Kit experiences.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
    K[isaaclab.python.kit] --> P[_parse_kit_asset_root]
    P --> U[_US_ASSET_ROOT]
    U --> S[US storage profile]
    E[ISAACSIM_ASSET_ROOT] --> R[_resolve_asset_root]
    S --> R
    R --> N[NUCLEUS_ASSET_ROOT_DIR]
Loading

Reviews (2): Last reviewed commit: "Initialize US asset root from Kit config..." | Re-trigger Greptile

@isaaclab-review-bot isaaclab-review-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isaac Lab Review Bot

The us asset region profile now resolves through the shipped Kit configuration, and all six shipped experiences consistently use the production 6.1 asset root.

  • Design and architecture: The Kit experience is now the single source of truth for the us root, while the China profile retains its explicit regional override. The directory-wide regression test deliberately requires every apps/*.kit experience to define identical default, cloud, and nvidia roots, so future inherited or specialized experiences would require updating that contract and test.
  • API: Asset-root precedence remains ISAACSIM_ASSET_ROOT, then a profile-specific override, then the Kit configuration. Exported root constants retain their types and derivation; the removed _US_ASSET_ROOT symbol was private, and the optional asset_root profile field is handled with a guarded lookup. The behavior change is recorded in the changelog fragment.
  • Implementation: The environment override, China profile override, empty us profile, Kit parser fallback, and all six changed experience files were traced consistently. Tests cover us fallback and production-root alignment. The remaining operational dependency is that the production bucket contains the referenced 6.1 assets.

No blocking issues. No inline issue met the actionable-evidence threshold; the assessment above records the review feedback.

Automated review; human maintainers own approval decisions.

@kellyguo11

Copy link
Copy Markdown
Contributor Author

@greptile-apps

@kellyguo11

Copy link
Copy Markdown
Contributor Author

run-ci

@isaaclab-bot isaaclab-bot Bot added ci:run-docker Trigger the on-demand Docker and GPU CI workflow and removed ci:run-docker Trigger the on-demand Docker and GPU CI workflow labels Sep 5, 2026
@kellyguo11
kellyguo11 merged commit f754f29 into isaac-sim:develop Sep 5, 2026
113 of 116 checks passed
@isaaclab-bot

isaaclab-bot Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Backported to release/3.0.0 as 21152a5.

isaaclab-bot Bot pushed a commit that referenced this pull request Sep 5, 2026
# Description

Uses the shipped Kit experience as the single source of truth for the
`us` Asset Region Profile instead of duplicating the production asset
URL in Python.

All six shipped `.kit` experiences now use the production asset root for
their `default`, `cloud`, and `nvidia` settings. Focused regression
coverage verifies that `_US_ASSET_ROOT` is initialized by the Kit
parser, the `us` profile keeps its existing resolution path, and every
shipped experience remains aligned with the canonical production root.

Follow-up to #7549. No additional dependencies are required.

## Type of change

- Bug fix (non-breaking change which fixes an issue)

## Release backport

- [x] <!-- backport-active-release --> Backport this pull request to the
active release branch after it merges into `develop`

## Screenshots

Not applicable.

## Checklist

Docker and GPU tests run on demand. Push the commits you want tested,
then
comment `run-ci` on the pull request.

- [x] I have read and understood the [contribution
guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html)
- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) on
the changed files
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] I have added a changelog fragment under
`source/<pkg>/changelog.d/` for every touched package
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there

## Validation

- The two focused regression checks fail against the pre-fix #7549 head
and pass with this change.
- `13 passed, 48 deselected` for the asset-root and Kit-experience
subset of `test_assets.py`.
- All pre-commit hooks passed on the changed files, including Ruff,
formatting, codespell, changelog validation, and Git LFS pointer
validation.
- Python compilation and `git diff --check` passed.
- Full `uv run isaaclab -f` was unavailable locally because the project
lockfile does not support macOS; the equivalent changed-file pre-commit
suite passed.

(cherry picked from commit f754f29)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

isaac-lab Related to Isaac Lab team isaac-sim Related to Isaac Sim team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant