Add MAPPO to multi-agent documentation commands - #7605
Conversation
Greptile SummaryThis PR updates generated environment-browser commands to select SKRL MAPPO for tasks that register a MAPPO configuration.
Confidence Score: 5/5The PR appears safe to merge; the generated MAPPO argument is correctly scoped to compatible SKRL tasks and accepted by both command modes. No actionable failures remain: positional row generation is consistent, command state does not retain stale algorithms, and MAPPO resolves to registered configurations for both affected tasks. Important Files Changed
Reviews (1): Last reviewed commit: "Add MAPPO to multi-agent documentation c..." | Re-trigger Greptile |
There was a problem hiding this comment.
Isaac Lab Review Bot
Reviewed the environment-browser row-schema extension that records MAPPO as SKRL’s generated-command default for registered multi-agent tasks. The generated rows and command builder consistently produce --algorithm MAPPO for the two affected tasks without changing other generated commands.
- Design and architecture: The generator derives an optional per-library default-algorithm map from registered SKRL configurations, while the browser remains responsible for command assembly. This preserves the existing generated-data/consumer split. MAPPO preference is currently encoded as generator policy, so supporting a task that registers MAPPO but prefers another default would require refining that policy.
- API: The positional row format remains compatible with existing rows: JavaScript defaults the new ninth field to an empty object, prior preview and warp slots retain their positions, and preview-image collection continues reading index 6. Explicit runtime algorithm selection is unaffected.
- Implementation: The revised padding conditions correctly emit the optional compatibility, preview, warp, and algorithm fields in sequence. The regenerated task rows match the new renderer, and command generation adds the algorithm only when the selected RL library has a configured default. The focused regression test covers MAPPO metadata emission.
No blocking issues. No inline issue met the actionable-evidence threshold; the assessment above records the review feedback.
Automated review; human maintainers own approval decisions.
|
run-ci |
Description
The environment browser advertises SKRL support for the native multi-agent tasks but previously omitted the algorithm from its generated commands. SKRL consequently used its PPO default, converted the environment to single-agent form, and selected the wrong algorithm for pretrained-checkpoint lookup.
This change marks MAPPO as the generated-command default whenever a task registers an SKRL MAPPO configuration, then appends
--algorithm MAPPOin the environment browser. Explicit runtime algorithm selection remains unchanged, so other algorithm checkpoints are still supported.This currently updates the generated commands for:
Isaac-Pendulum-MARL-DirectIsaac-Shadow-Handover-DirectTracks NVBug 6675391. No matching existing PR was found; #7360 addresses the separate benchmark play environment-creation path.
No new dependencies are required.
Type of change
Release backport
developScreenshots
Not applicable. A headless browser smoke test generated:
uv run --extra skrl isaaclab train --rl_library skrl --task Isaac-Shadow-Handover-Direct --algorithm MAPPO physics=newton_mjwarpValidation
uv run --extra test python -m pytest --confcutdir=tools/test tools/test/test_environ_docs.py -q(28 passed)uv run --isolated --extra dev --extra ov -- make -C docs current-docs(passed)uv run isaaclab -f(passed)Checklist
uv run isaaclab -fCONTRIBUTORS.md