evolutive postprocessing - #45
Open
mikesndrs wants to merge 2 commits into
Open
Conversation
SBlokhuizen
reviewed
Sep 9, 2026
| @@ -0,0 +1,218 @@ | |||
| """ | |||
Collaborator
There was a problem hiding this comment.
Would it be nice to add to the workflows docs examples of their respective postprocessing plots, if applicable?
SBlokhuizen
reviewed
Sep 9, 2026
Comment on lines
+91
to
+93
| "dina": DBEntry(f"imas:hdf5?path={args.dina_uri}", "r"), | ||
| "reconstruction": DBEntry(f"imas:hdf5?path={args.reconstruction_uri}", "r"), | ||
| "nice": DBEntry(f"imas:hdf5?path={args.nice_uri}", "r"), |
Collaborator
There was a problem hiding this comment.
From this, args.dina_uri seems to be a path, not an URI. Can you update the naming to reflect this? Similar for the other 2.
| db.close() | ||
|
|
||
|
|
||
| def rz_ip_plot(args, dbs): |
Collaborator
There was a problem hiding this comment.
Would it make more sense to pass the IDSs here?
Collaborator
|
Can you check why the CI fails? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.