Admit an event instant and the signal-to-noise ratio and level pair - #36
Merged
Merged
Conversation
Add a scalar event_instant base for the time-coordinate value at which a discrete event occurs. Its definition distinguishes the instant from elapsed duration and from the sampled time axis.
Define signal_to_noise_ratio as the linear dimensionless power quotient and add signal_to_noise_level for its logarithmic decibel representation. The separate bases preserve the nonlinear semantic and unit distinction.
event_instant is the time-coordinate value at which a discrete event occurs, distinct from elapsed duration and from the sampled axis. signal_to_noise_ratio is the linear dimensionless quotient and signal_to_noise_level its decibel representation, kept separate because the unit distinction is real.
event_instant plus the signal-to-noise ratio and level pair are admitted, and the release level is locked as a stable patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Admits three
physical_basetokens the WEST standard-name batch needs, and settles a unit question by splitting rather than choosing.event_instantA scalar for the time-coordinate value at which a discrete event occurs. The consumer is the Data Dictionary path
summary/disruption/time/value, which had no admissible base.Three meanings have to stay distinct, and the definition says which one this denotes and which two it excludes: the instant an event occurs, an elapsed duration, and the sampled time axis. A token conflating them composes onto the wrong sources.
The grammar was probed first to check whether it could already express an instant. It can parse
instantaneous_timeas qualifierinstantaneousplus basetime, whileevent_time,occurrence_timeandevent_instantwere all rejected. That spelling was judged not to carry event-instant semantics: basetimeis the coordinate axis, soinstantaneous_timereads as the axis sampled instantaneously rather than the instant an event occurred. Hence a distinct base.signal_to_noise_ratioandsignal_to_noise_levelOne prior note recorded signal-to-noise as decibels; a consuming plan described it as dimensionless. Those are different admissions with different composition consequences, so both are admitted with the distinction made explicit:
signal_to_noise_ratio1signal_to_noise_levelCollapsing them would either lose the decibel form diagnostics actually report, or hang a decibel unit on a ratio. The dimensionless unit is the string
1, not an absent unit — a null unit is a different and wrong state.Verification
build-grammar --checkexits 0 with generated files in sync.Intended to be followed by a stable patch release,
v0.9.1, cut through the release CLI so the tag drives the version.