Skip to content

Bump MUSCLE3 version to >=0.10.0 - #188

Merged
SBlokhuizen merged 7 commits into
developfrom
feature/muscle-v0.10
Sep 9, 2026
Merged

Bump MUSCLE3 version to >=0.10.0#188
SBlokhuizen merged 7 commits into
developfrom
feature/muscle-v0.10

Conversation

@SBlokhuizen

@SBlokhuizen SBlokhuizen commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Bump the MUSCLE3 and yMMSL dependencies of the plasma shape editor so you can use the new 2025b NICE module available on SDCC: NICE/3.0.0-intel-2025b-DD-4.1.1

@SBlokhuizen
SBlokhuizen marked this pull request as draft September 4, 2026 07:51
@SBlokhuizen
SBlokhuizen marked this pull request as ready for review September 4, 2026 08:14

@maarten-ic maarten-ic left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts below and please check why CI is failing on docs.

Could you also check if that CI step is still required in GitHub Actions? ReadTheDocs also builds documentation, and perhaps we can configure RTD so we don't need it in GH Actions anymore? This may be useful for reference: iterorganization/IMAS-Python#111

Comment thread docs/source/installing.rst
Comment thread docs/source/shape_editor_install.rst
@SBlokhuizen

Copy link
Copy Markdown
Collaborator Author

Could you also check if that CI step is still required in GitHub Actions? ReadTheDocs also builds documentation, and perhaps we can configure RTD so we don't need it in GH Actions anymore? This may be useful for reference: iterorganization/IMAS-Python#111

This I will do in a separate PR: #189

Comment thread waveform_editor/shape_editor/nice_integration.py
Comment thread docs/source/shape_editor_install.rst
Comment thread docs/source/installing.rst

@mikesndrs mikesndrs left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update muscle3 actor docs 'implementations' example to 'programs'

@SBlokhuizen
SBlokhuizen merged commit 850fce8 into develop Sep 9, 2026
6 checks passed
@SBlokhuizen
SBlokhuizen deleted the feature/muscle-v0.10 branch September 9, 2026 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants