Repository navigation
Commit 367417a
committed
fix(mlops): Return a real bool from _is_collection_column; drop stale patch
Two unit-test failures introduced by the lint pass:
- feature_utils._is_collection_column is annotated ``-> bool`` but
returned ``Series.any()``, a numpy.bool_. The tests compared with
``== True``; changing them to ``is True`` (E712) exposed the mismatch.
Wrap the result in ``bool()`` so the function honours its annotation.
- test_feature_scheduler.test_to_pipeline patched
``_config_uploader.TrainingInput``, a name that module imported but
never used. Removing the unused import (F401) made the patch fail with
AttributeError. The patch never affected the test (the mock argument
was unused), so the decorator and its parameter are removed.1 parent 96eef7c commit 367417a
2 files changed
Lines changed: 1 addition & 3 deletions
File tree
- sagemaker-mlops
- src/sagemaker/mlops/feature_store
- tests/unit/sagemaker/mlops/feature_store/feature_processor
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
374 | 374 | | |
375 | 375 | | |
376 | 376 | | |
377 | | - | |
| 377 | + | |
378 | 378 | | |
379 | 379 | | |
380 | 380 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
176 | 176 | | |
177 | 177 | | |
178 | 178 | | |
179 | | - | |
180 | 179 | | |
181 | 180 | | |
182 | 181 | | |
| |||
228 | 227 | | |
229 | 228 | | |
230 | 229 | | |
231 | | - | |
232 | 230 | | |
233 | 231 | | |
234 | 232 | | |
| |||
0 commit comments