Repository navigation
Commit 9024f9d
committed
test(core): Patch os.name in the Windows _HostingContainer.down test
test_hosting_container_down_windows was one of the duplicate test
definitions this branch un-shadowed, so it ran for the first time in CI
and failed with ``ValueError: Invalid PID``. It patched
``platform.system`` to return "Windows", but ``_HostingContainer.down``
branches on ``os.name != "nt"``, so on the Linux runner it still called
``kill_child_processes`` with a Mock pid. Patch ``os.name`` in the module
under test instead, which exercises the Windows branch the test describes.1 parent f2ef154 commit 9024f9d
1 file changed
Lines changed: 2 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
516 | 516 | | |
517 | 517 | | |
518 | 518 | | |
519 | | - | |
520 | | - | |
| 519 | + | |
| 520 | + | |
521 | 521 | | |
522 | | - | |
523 | 522 | | |
524 | 523 | | |
525 | 524 | | |
| |||
0 commit comments