fix: Banner + USB + Recording Service issue after switching

Author: jamakr4

README.md

@@ -60,11 +60,11 @@ Community mod for the MG4 EV (AAOS 9, pre-2026 facelift) that replaces the stock
 
 <p align="center">
   <img src="images/blinker_cam_v2.gif" alt="Turn signal overlay" width="48%">
-  &nbsp;
   <img src="images/dashcam_demo_v3.gif" alt="Dashcam mode" width="48%">
+
 </p>
 
-<p align="right">
+<p align="center">
   <a href="https://youtu.be/Rzb_Owc_RT0">▶ Full demo on YouTube</a>
 </p>
 

app/src/main/java/com/drivehub/kamera/dashcam/DashcamSettingsController.java

@@ -249,6 +249,13 @@ private void bindStorageGroup(SharedPreferences prefs, StorageViews views) {
                     if (g.getChildAt(i).getId() == checkedId) {
                         DashcamStorageManager.setStorageTarget(prefs, i);
                         refreshStorageStatus(prefs, views);
+                        // USB-only without USB makes the recording loop end with a fatal error
+                        // and stopSelf(); the service is then gone until the user toggles the
+                        // dashcam off+on. Switching the target should be enough — kick the
+                        // service back up if it's idle while the dashcam is enabled.
+                        if (prefs.getBoolean(KEY_ENABLED, false) && !RecordingService.isRunning()) {
+                            RecordingService.startIfDashcamEnabled(activity);
+                        }
                         break;
                     }
                 }

app/src/main/java/com/drivehub/kamera/dashcam/DashcamStorageManager.java

@@ -47,6 +47,7 @@ public final class DashcamStorageManager {
 
     private static final String USB_RECORDS_DIR_NAME = "dashcam";
     private static final String WRITE_PROBE_FILE_NAME = ".dashcam_write_probe";
+    private static final File LEGACY_STORAGE_ROOT = new File("/storage");
 
     public enum UsbState {
         NOT_CHECKED,        // INTERNAL_ONLY mode: USB is deliberately ignored
@@ -192,6 +193,18 @@ private static final class UsbCandidate {
      */
     private static UsbProbe probeUsb(Context context) {
         List<UsbCandidate> candidates = findUsbCandidates(context);
+        if (candidates.isEmpty()) {
+            // AAOS 9 head units typically don't surface OTG/USB volumes via StorageManager:
+            // the OS mounts them under /mnt/media_rw/... without registering them with the
+            // MediaProvider, so getExternalFilesDirs() returns nothing usable. Fall back to a
+            // direct /storage scan, which is how every dashcam-style automotive app has to
+            // handle this in practice.
+            candidates = findLegacyStorageCandidates();
+            if (!candidates.isEmpty()) {
+                Log.i(TAG, "StorageManager exposed no removable volumes; using /storage scan ("
+                        + candidates.size() + " candidate(s))");
+            }
+        }
         if (candidates.isEmpty()) {
             return new UsbProbe(UsbState.NO_MEDIUM, null);
         }
@@ -256,6 +269,27 @@ private static List<UsbCandidate> findUsbCandidates(Context context) {
         return new ArrayList<>(deduped.values());
     }
 
+    /**
+     * Last-resort enumeration: list every directory under /storage that isn't the emulated
+     * primary volume or the "self" symlink. No StorageManager metadata, no isRemovable hints,
+     * just whatever the user can mount and read. Suitability is decided by the write probe.
+     */
+    private static List<UsbCandidate> findLegacyStorageCandidates() {
+        List<UsbCandidate> candidates = new ArrayList<>();
+        File[] children = LEGACY_STORAGE_ROOT.listFiles();
+        if (children == null) {
+            return candidates;
+        }
+        for (File child : children) {
+            if (child == null || !child.isDirectory()) continue;
+            String name = child.getName();
+            if (name.isEmpty() || "emulated".equals(name) || "self".equals(name)) continue;
+            if (!child.canRead()) continue;
+            candidates.add(new UsbCandidate(child, name, looksLikeUsb(child, name)));
+        }
+        return candidates;
+    }
+
     private static List<UsbCandidate> prioritizeUsbCandidates(List<UsbCandidate> candidates) {
         List<UsbCandidate> usbLike = new ArrayList<>();
         List<UsbCandidate> genericRemovable = new ArrayList<>();

app/src/main/java/com/drivehub/kamera/signal/SignalService.java

@@ -348,8 +348,20 @@ private void startOemLifecycleMonitor() {
         oemLifecycleThread.start();
         oemLifecycleHandler = new Handler(oemLifecycleThread.getLooper());
         oemLifecycleMonitoring = true;
-        lastOemLifecycle = readStringSystemProperty(OEM_LIFECYCLE_PROP);
-        DevRuntimeLog.add("SignalService", "OEM lifecycle monitor started");
+        // The AVM sysprop is sticky across reboots — if the previous session ended with "Start"
+        // (crash, force-kill) and AVM is no longer actually in the foreground, treating that
+        // stale value as the baseline causes the next genuine open→close cycle to fire a
+        // "resume" without a preceding "pause". Reset stale Starts to DestroyEnd so the next
+        // real Start triggers the pause path correctly.
+        String initialState = readStringSystemProperty(OEM_LIFECYCLE_PROP);
+        if (OEM_LIFECYCLE_START.equals(initialState) && !isOemAvmInForeground()) {
+            DevRuntimeLog.add("SignalService",
+                    "OEM lifecycle: stale 'Start' on monitor start — resetting baseline");
+            initialState = OEM_LIFECYCLE_DESTROYED;
+        }
+        lastOemLifecycle = initialState;
+        DevRuntimeLog.add("SignalService",
+                "OEM lifecycle monitor started, initial='" + initialState + "'");
         oemLifecycleHandler.post(new Runnable() {
             @Override
             public void run() {