fix: remove toast + better logic for events folder

Author: jamakr4

app/src/main/java/com/drivehub/kamera/MainActivity.java

@@ -148,7 +148,6 @@ protected void onCreate(Bundle savedInstanceState) {
                 return;
             }
             RecordingService.triggerEventSave(this);
-            Toast.makeText(this, R.string.main_event_save_armed, Toast.LENGTH_SHORT).show();
         });
 
         applyStoredRecordingStatus();

app/src/main/java/com/drivehub/kamera/dashcam/RecordingService.java

@@ -235,8 +235,9 @@ public int onStartCommand(Intent intent, int flags, int startId) {
             if (worker == null || !prefs().getBoolean(DashcamSettingsController.KEY_ENABLED, false)) {
                 return START_STICKY;
             }
-            armEventCapture();
-            DashcamEventOverlayService.showConfirmation(this);
+            if (armEventCapture()) {
+                DashcamEventOverlayService.showConfirmation(this);
+            }
             return START_STICKY;
         }
 
@@ -433,20 +434,35 @@ private void onSegmentCompleted(File baseDir, String baseName, long startMs, lon
         }
     }
 
-    private void armEventCapture() {
+    private boolean armEventCapture() {
         long now = System.currentTimeMillis();
         String eventBaseName = "event_" + makeTimestampBase(now, "yyMMddHHmmssSSS");
-        File eventDir = new File(getEventsBaseDir(), eventBaseName);
-        // noinspection ResultOfMethodCallIgnored
-        eventDir.mkdirs();
+        File eventsBaseDir = getEventsBaseDir();
+        if (eventsBaseDir == null) {
+            DevRuntimeLog.add("RecordingService", "Event capture failed: events base dir unavailable");
+            Log.e(TAG, "Failed to arm event capture because events base dir is unavailable");
+            return false;
+        }
+        File eventDir = new File(eventsBaseDir, eventBaseName);
+        if (!ensureDirectoryExists(eventDir, "event dir")) {
+            DevRuntimeLog.add("RecordingService", "Event capture failed: mkdir " + eventDir.getAbsolutePath());
+            Log.e(TAG, "Failed to create event dir " + eventDir.getAbsolutePath());
+            return false;
+        }
         synchronized (eventLock) {
             long currentSegmentOrdinal = completedSegmentCount + 1L;
             pendingEventRequests.add(new EventCaptureRequest(
                     eventBaseName,
                     Math.max(1L, currentSegmentOrdinal - EVENT_SEGMENTS_BEFORE_CURRENT),
                     currentSegmentOrdinal + EVENT_SEGMENTS_AFTER_CURRENT
             ));
+            DevRuntimeLog.add(
+                    "RecordingService",
+                    "Event armed: " + eventBaseName
+                            + " ordinals " + Math.max(1L, currentSegmentOrdinal - EVENT_SEGMENTS_BEFORE_CURRENT)
+                            + "-" + (currentSegmentOrdinal + EVENT_SEGMENTS_AFTER_CURRENT));
         }
+        return true;
     }
 
     private List<EventCopyJob> collectEventCopyJobsLocked(long completedThroughOrdinal) {
@@ -492,9 +508,19 @@ private void copyEventSegments(EventCopyJob job) {
             Log.w(TAG, "Skipping empty event copy job for " + job.eventBaseName);
             return;
         }
-        File eventDir = new File(getEventsBaseDir(), job.eventBaseName);
-        // noinspection ResultOfMethodCallIgnored
-        eventDir.mkdirs();
+        File eventsBaseDir = getEventsBaseDir();
+        if (eventsBaseDir == null) {
+            DevRuntimeLog.add("RecordingService", "Event copy failed: events base dir unavailable");
+            Log.e(TAG, "Failed to copy event segments because events base dir is unavailable");
+            return;
+        }
+        File eventDir = new File(eventsBaseDir, job.eventBaseName);
+        if (!ensureDirectoryExists(eventDir, "event dir")) {
+            DevRuntimeLog.add("RecordingService", "Event copy failed: mkdir " + eventDir.getAbsolutePath());
+            Log.e(TAG, "Failed to create event dir " + eventDir.getAbsolutePath());
+            return;
+        }
+        DevRuntimeLog.add("RecordingService", "Event copy: " + job.eventBaseName + " files " + job.baseNames.size());
         for (String baseName : job.baseNames) {
             copySegmentGroup(DashcamSettingsController.getRecordsBaseDir(this), eventDir, baseName);
         }
@@ -603,22 +629,39 @@ private void cleanupOldSegments(File baseDir, int keepSegments, Set<String> prot
 
     private File getEventsBaseDir() {
         File dir = new File(DashcamSettingsController.getRecordsBaseDir(this), "events");
-        // noinspection ResultOfMethodCallIgnored
-        dir.mkdirs();
-        return dir;
+        return ensureDirectoryExists(dir, "events base dir") ? dir : null;
     }
 
     private File requireBaseDir() {
         File baseDir = DashcamSettingsController.getRecordsBaseDir(this);
-        // noinspection ResultOfMethodCallIgnored
-        baseDir.mkdirs();
-        if (baseDir.exists() && baseDir.canWrite()) {
+        if (ensureDirectoryExists(baseDir, "records base dir") && baseDir.canWrite()) {
             return baseDir;
         }
         publishStatus(STATUS_ERROR, 0, TOTAL_CAMERAS, "storage not writable");
         return null;
     }
 
+    private boolean ensureDirectoryExists(File dir, String label) {
+        if (dir == null) {
+            return false;
+        }
+        if (dir.exists()) {
+            if (dir.isDirectory()) {
+                return true;
+            }
+            Log.e(TAG, label + " exists but is not a directory: " + dir.getAbsolutePath());
+            return false;
+        }
+        if (dir.mkdirs()) {
+            return true;
+        }
+        boolean created = dir.exists() && dir.isDirectory();
+        if (!created) {
+            Log.e(TAG, "Failed to create " + label + ": " + dir.getAbsolutePath());
+        }
+        return created;
+    }
+
     private String makeTimestampBase(long epochMs, String pattern) {
         return new SimpleDateFormat(pattern, Locale.US).format(epochMs);
     }

app/src/main/res/values-de/strings.xml

@@ -107,7 +107,6 @@
     <string name="main_button_trigger_event_save">Letzte + nächste Minute speichern</string>
     <string name="main_button_record_test_30s">30s Test aufnehmen</string>
     <string name="main_button_record_test_running">30s Aufnahme läuft…</string>
-    <string name="main_event_save_armed">Event-Speicherung aktiviert</string>
     <string name="main_event_save_requires_dashcam">Erst die Dashcam-Aufnahme aktivieren</string>
     <string name="main_recording_indicator">%1$d/%2$d</string>
     <string name="main_recording_starting">REC startet</string>

app/src/main/res/values/strings.xml

@@ -107,7 +107,6 @@
     <string name="main_button_trigger_event_save">Save last + next minute</string>
     <string name="main_button_record_test_30s">Record 30s Test</string>
     <string name="main_button_record_test_running">Recording 30s…</string>
-    <string name="main_event_save_armed">Event save armed</string>
     <string name="main_event_save_requires_dashcam">Enable dashcam recording first</string>
     <string name="main_recording_indicator">%1$d/%2$d</string>
     <string name="main_recording_starting">REC starting</string>