Repository navigation
Commit 2cec6d2
Remove the index.html integrity "workaround" (no such Electron gap)
bf33dba added `fs.readFileSync(index.html)` before loadFile, with a
comment saying Electron 44's asar-integrity check skipped the
main-frame load of index.html. That observation was wrong. A separate
investigation (two independent builds, fuse wire read back from each
exe, exe/asar header hash verified before every run) found a tampered
index.html is rejected with or without the extra read
(asar_file_validator.cc), in a minimal app and in NoteForge HEAD with
the line stripped. The likely cause of the original result was a
stale build artifact in the test setup.
Drops the line and the comment so the repo no longer asserts a
non-existent Electron bug, and corrects the 2.8.0 CHANGELOG note.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>1 parent d82d024 commit 2cec6d2
2 files changed
Lines changed: 4 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
8 | 11 | | |
9 | 12 | | |
10 | 13 | | |
| |||
24 | 27 | | |
25 | 28 | | |
26 | 29 | | |
27 | | - | |
| 30 | + | |
28 | 31 | | |
29 | 32 | | |
30 | 33 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
745 | 745 | | |
746 | 746 | | |
747 | 747 | | |
748 | | - | |
749 | | - | |
750 | | - | |
751 | | - | |
752 | | - | |
753 | 748 | | |
754 | 749 | | |
755 | 750 | | |
| |||
0 commit comments