Skip to content

fix: sanitize child_process call in release-prepare.cjs... #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anupamme wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: sanitize child_process call in release-prepare.cjs... #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions scripts/release-prepare.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,19 @@
#!/usr/bin/env node

const { execSync } = require('child_process')
const { execSync, execFileSync } = require('child_process')
const path = require('path')
const fs = require('fs')

const rootDir = path.resolve(__dirname, '..')
const bump = (process.argv[2] || 'patch').toLowerCase()
const validBumps = new Set(['patch', 'minor', 'major'])

const run = cmd => execSync(cmd, { cwd: rootDir, stdio: 'pipe' }).toString().trim()

if (!validBumps.has(bump)) {
console.error(`Invalid bump "${bump}". Use one of: patch, minor, major`)
process.exit(1)
}

const branch = run('git rev-parse --abbrev-ref HEAD')
const branch = execFileSync('git', ['rev-parse', '--abbrev-ref', 'HEAD'], { cwd: rootDir, stdio: 'pipe' }).toString().trim()
if (branch === 'master') {
console.error('Refusing to prepare release on master. Create or switch to a release branch first.')
process.exit(1)
Expand All @@ -37,7 +36,7 @@ if (hasUncommitted) {
execSync(`npm version ${bump} --no-git-tag-version`, { cwd: rootDir, stdio: 'inherit' })
execSync('npm run manifest:firefox', { cwd: rootDir, stdio: 'inherit' })

const version = run("node -p \"require('./package.json').version\"")
const version = JSON.parse(fs.readFileSync(path.join(rootDir, 'package.json'), 'utf8')).version
execSync('git add package.json package-lock.json manifest.json', { cwd: rootDir, stdio: 'inherit' })
execSync(`git commit -m "chore(release): v${version}"`, { cwd: rootDir, stdio: 'inherit' })

Expand Down