fixed tui breaking on chat list

Author: jameswexler1

PLAN.md

@@ -29,7 +29,7 @@ Implementation is past the local-shell phase and currently sits at a DB-first, l
 - Chat title quality tracking with source precedence, group/contact metadata refresh, and safe placeholders so group JIDs/phone-like IDs are not treated as real names.
 - Direct-chat identity hardening for WhatsApp PN/LID aliases: canonicalize mapped 1:1 chats onto a single chat ID, merge already-split alias rows/messages/drafts/history cursors in SQLite, and preserve the active conversation when a live merge remaps the selected chat.
 - Large-history TUI guardrails: paired live startup immediately shows a blocking sync/check overlay only for local DB catch-up, historical imports avoid refresh storms, implicit database imports show a blocking local-update progress overlay even when WhatsApp omits an offline-sync preview, reconnect catch-up sync batches snapshot refreshes until completion, live refreshes are debounced, chat-list preview text is stored on chats instead of recomputed through per-chat message subqueries during every refresh, preview recomputation is skipped for older message/media mutations that cannot affect the latest chat preview, stale snapshot reloads do not steal chat focus, message rendering and cursor visibility use full message coordinates while clipping the final viewport, message cursor scrolling behaves like the chat list viewport, duplicate in-flight history requests are suppressed, send/draft/read-receipt/reaction/retry/sticker/lazy-load/history/filter/mention TUI callbacks return asynchronous result messages instead of blocking `Update`, message filtering uses the maintained FTS index instead of a chat-wide scan, UI-facing store callbacks use bounded contexts, remote media and sticker download work observes caller deadlines, clipboard image transfer has bounded memory/file-size limits, desktop notification bursts surface backpressure instead of silently dropping everything, and pixel media/avatar/sticker overlays keep low-resolution fallbacks visible while sync is pending, avoid chat-avatar overlay pauses on snapshot reloads when the visible avatar placement inputs are unchanged, reserve blank space only while paused for scroll/focus/resize transitions, then resync with bounded sync contexts and a one-shot retry after overlay sync failure.
-- Terminal/UI polish for real chat data: full/compat/auto emoji rendering, stable emoji fallback for terminals such as `st`, Windows Terminal, and classic Windows console hosts, Windows console output-mode setup with a two-column guarded render width plus a final frame clamp to avoid edge-wrap frame corruption, Windows terminal-size polling plus a lower default renderer FPS for smoother ConPTY behavior, pywal-backed mode indicators with per-mode hex overrides, focused-pane borders that distinguish chat-list vs message-pane input focus, highlighted unread-count badges in the chat list, a structured keymap-driven help screen, non-redundant mode prompts, configurable help/prompt key hints, search match counts in the status bar, configurable cancellation/search-clear bindings, platform-specific terminal focus-reporting options, and native Windows runtime defaults that do not affect Linux behavior.
+- Terminal/UI polish for real chat data: full/compat/auto emoji rendering, stable emoji fallback for terminals such as `st`, Windows Terminal, and classic Windows console hosts, Windows console output-mode setup with a two-column guarded render width plus a final frame clamp to avoid edge-wrap frame corruption, Unix terminfo detection that enables the same last-column guard for `am+xenl` terminals such as `st`, Windows terminal-size polling plus a lower default renderer FPS for smoother ConPTY behavior, pywal-backed mode indicators with per-mode hex overrides, focused-pane borders that distinguish chat-list vs message-pane input focus, highlighted unread-count badges in the chat list, a structured keymap-driven help screen, non-redundant mode prompts, configurable help/prompt key hints, search match counts in the status bar, configurable cancellation/search-clear bindings, platform-specific terminal focus-reporting options, and native Windows runtime defaults that do not affect Linux behavior.
 - Search now folds accents only for accent-free queries, so `/Jose` matches `José` while `/José` stays accent-sensitive, with matching highlight behavior in the TUI and the same rule in store-backed chat/message filtering.
 - Demo/dev workflows that exercise the full local UI without a live WhatsApp session.
 

go.mod

@@ -9,6 +9,7 @@ require (
 	github.com/mdp/qrterminal/v3 v3.2.1
 	github.com/muesli/termenv v0.16.0
 	github.com/rivo/uniseg v0.4.7
+	github.com/xo/terminfo v0.0.0-20220910002029-abceb7e1c41e
 	go.mau.fi/whatsmeow v0.0.0-20260123225751-89be06b020db
 	modernc.org/sqlite v1.48.2
 )
@@ -37,7 +38,6 @@ require (
 	github.com/remyoudompheng/bigfft v0.0.0-20230129092748-24d4a6f8daec // indirect
 	github.com/rs/zerolog v1.34.0 // indirect
 	github.com/vektah/gqlparser/v2 v2.5.27 // indirect
-	github.com/xo/terminfo v0.0.0-20220910002029-abceb7e1c41e // indirect
 	go.mau.fi/libsignal v0.2.1 // indirect
 	go.mau.fi/util v0.9.5 // indirect
 	golang.org/x/crypto v0.47.0 // indirect

internal/ui/model_test.go

@@ -3399,6 +3399,46 @@ func TestChatTopAndBottomCommandsKeepActiveCellVisible(t *testing.T) {
 	}
 }
 
+func TestChatTopNavigationWithLastColumnGuardDoesNotTouchTerminalEdge(t *testing.T) {
+	chats := numberedChats(8)
+	chats[0].Unread = 20
+	chats[0].AvatarPath = "/tmp/avatar-top.jfif"
+	messages := map[string][]store.Message{}
+	for _, chat := range chats {
+		messages[chat.ID] = nil
+	}
+	model := NewModel(Options{
+		ReserveLastColumn: true,
+		Snapshot: store.Snapshot{
+			Chats:          chats,
+			MessagesByChat: messages,
+			DraftsByChat:   map[string]string{},
+			ActiveChatID:   "chat-7",
+		},
+	})
+	model.width = 80
+	model.height = 24
+	model.focus = FocusChats
+
+	top, _ := model.updateNormal(tea.KeyMsg{Type: tea.KeyRunes, Runes: []rune("g")})
+	model = top.(Model)
+	if model.activeChat != 0 || model.chatScrollTop != 0 {
+		t.Fatalf("g activeChat=%d chatScrollTop=%d, want top visible", model.activeChat, model.chatScrollTop)
+	}
+
+	view := stripANSI(model.View())
+	lines := strings.Split(view, "\n")
+	if len(lines) > model.height {
+		t.Fatalf("View() produced %d lines, want <= %d\n%s", len(lines), model.height, view)
+	}
+	maxWidth := model.width - lastColumnGuardMargin
+	for i, line := range lines {
+		if width := lipgloss.Width(line); width > maxWidth {
+			t.Fatalf("line %d width = %d, want <= %d with last-column guard\n%s", i+1, width, maxWidth, view)
+		}
+	}
+}
+
 func TestChatSearchKeepsMatchedCellVisible(t *testing.T) {
 	chats := numberedChats(8)
 	chats[6].Title = "Needle Team"

internal/ui/terminal_output_unix.go

@@ -2,12 +2,48 @@
 
 package ui
 
-import "runtime"
+import (
+	"fmt"
+	"os"
+	"runtime"
+	"strings"
+
+	"github.com/xo/terminfo"
+)
 
 func prepareTerminalOutput() (TerminalReport, func() error) {
-	return TerminalReport{
+	report := TerminalReport{
 		Platform:       runtime.GOOS,
 		VTProcessing:   true,
 		DelayedNewline: true,
-	}, func() error { return nil }
+	}
+	applyUnixLastColumnGuard(&report, os.Getenv("TERM"), terminfo.LoadFromEnv)
+	return report, func() error { return nil }
+}
+
+func applyUnixLastColumnGuard(report *TerminalReport, term string, load func() (*terminfo.Terminfo, error)) {
+	if report == nil || load == nil {
+		return
+	}
+	info, err := load()
+	if err != nil {
+		return
+	}
+	if !unixNeedsLastColumnGuard(info) {
+		return
+	}
+	report.LastColumnGuard = true
+	detail := "last-column guard enabled by terminfo am+xenl"
+	if term = strings.TrimSpace(term); term != "" {
+		detail = fmt.Sprintf("last-column guard enabled for TERM=%s by terminfo am+xenl", term)
+	}
+	report.Detail = joinTerminalDetails(report.Detail, detail)
+}
+
+func unixNeedsLastColumnGuard(info *terminfo.Terminfo) bool {
+	return unixBoolCap(info, terminfo.AutoRightMargin) && unixBoolCap(info, terminfo.EatNewlineGlitch)
+}
+
+func unixBoolCap(info *terminfo.Terminfo, cap int) bool {
+	return info != nil && info.Bools != nil && info.Bools[cap]
 }

internal/ui/terminal_output_unix_test.go

@@ -0,0 +1,61 @@
+//go:build !windows
+
+package ui
+
+import (
+	"errors"
+	"strings"
+	"testing"
+
+	"github.com/xo/terminfo"
+)
+
+func TestUnixLastColumnGuardUsesTerminfoXenl(t *testing.T) {
+	report := TerminalReport{Platform: "linux", VTProcessing: true, DelayedNewline: true}
+
+	applyUnixLastColumnGuard(&report, "st-256color", func() (*terminfo.Terminfo, error) {
+		return &terminfo.Terminfo{Bools: map[int]bool{
+			terminfo.AutoRightMargin:  true,
+			terminfo.EatNewlineGlitch: true,
+		}}, nil
+	})
+
+	if !report.LastColumnGuard {
+		t.Fatal("LastColumnGuard = false, want enabled for am+xenl terminal")
+	}
+	if !strings.Contains(report.Detail, "TERM=st-256color") || !strings.Contains(report.Detail, "am+xenl") {
+		t.Fatalf("Detail = %q, want terminfo guard context", report.Detail)
+	}
+}
+
+func TestUnixLastColumnGuardRequiresXenl(t *testing.T) {
+	report := TerminalReport{Platform: "linux", VTProcessing: true, DelayedNewline: true}
+
+	applyUnixLastColumnGuard(&report, "xterm-256color", func() (*terminfo.Terminfo, error) {
+		return &terminfo.Terminfo{Bools: map[int]bool{
+			terminfo.AutoRightMargin: true,
+		}}, nil
+	})
+
+	if report.LastColumnGuard {
+		t.Fatal("LastColumnGuard = true, want disabled without xenl")
+	}
+	if report.Detail != "" {
+		t.Fatalf("Detail = %q, want empty without guard", report.Detail)
+	}
+}
+
+func TestUnixLastColumnGuardIgnoresTerminfoLoadFailure(t *testing.T) {
+	report := TerminalReport{Platform: "linux", VTProcessing: true, DelayedNewline: true}
+
+	applyUnixLastColumnGuard(&report, "unknown", func() (*terminfo.Terminfo, error) {
+		return nil, errors.New("missing terminfo")
+	})
+
+	if report.LastColumnGuard {
+		t.Fatal("LastColumnGuard = true, want disabled when terminfo cannot be loaded")
+	}
+	if report.Detail != "" {
+		t.Fatalf("Detail = %q, want empty on load failure", report.Detail)
+	}
+}