Repository navigation
fix: security - patch undici, zod, sharp, brace-expansion, and source-map-js - #429
Merged
Merged
Conversation
Raise the undici 7 and 8 override floors and add a sharp floor so miniflare's exact pins cannot stay on the vulnerable releases. Refresh the lockfile for the packages whose parent ranges already allow the patched versions. Co-authored-by: Jared Wray <me@jaredwray.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #429 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 406 406
Branches 94 94
=========================================
Hits 406 406 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Security fix. No application code changes. The existing suite still passes at 100% coverage.
Summary
Lockfile refresh for the HIGH advisories still present on
main.braces@3.0.3andhttp-cache-semantics@4.2.0are unchanged; neither has a published fix. NominimumReleaseAgeExcludeor trust-policy exception was added. The 7-dayminimumReleaseAge(10080 minutes) still applies.undici(7.x)undici(8.x)8.12.3(published 2026-10-19) is still inside the cooldown and is not a security release on top of 8.12.2, so it was not used.zod.max()/.size()on arrays, sets, and maps ran after element parsing, so an oversized input was fully walked first. Fixed in 4.6.6. 4.6.7 (published 2026-10-12) is the newest 4.6 release outside the cooldown and contains that fix.writr@^4.5.4already allows it.sharp>=0.35.5.@img/sharp-libvipsmoves from 1.3.3 to 1.3.4 because 0.35.5 depends on it.brace-expansion(1.x)brace-expansion(5.x)source-map-jsminiflare@5.20260918.0-alpha(viawrangler) pinsundici@7.29.0andsharp@0.35.4exactly, so those two cannot reach the patched releases through a parent range. The existingundici@7/undici@8floors still admitted 7.30.0 and 8.11.2, so they are now>=7.30.1 <8and>=8.12.2 <9.sharpis a new override,>=0.35.5 <0.36, for the same exact pin. A wrangler bump that pulls a miniflare depending onsharp@0.35.5would jump wrangler from 4.135.0 to 4.150.0 or newer.zod,brace-expansion, andsource-map-jsalready fit parent ranges (writr/ AI SDK,minimatch@^1.1.7and^5.0.2,postcssandmagicast@^1.2.1), so they moved with the lockfile refresh and no new override.No direct runtime range in
package.jsonnames these packages.writris already at the only published version that satisfies^6.1.6.Test plan
pnpm whyshows onlyundici@7.30.1,undici@8.12.2,zod@4.6.7,sharp@0.35.5,brace-expansion@1.1.21,brace-expansion@5.0.12, andsource-map-js@1.2.2. The previous versions are gone frompnpm-lock.yaml.braces@3.0.3andhttp-cache-semantics@4.2.0are unchanged.pnpm test— 239 tests, 100% coveragepnpm buildon Node 22.22