have js load plotly json directly - #6264
Open
vandenman wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires jasp-stats/jaspBase#208 and jasp-stats/jaspGraphs#154
As we discussed in the meeting, before in jaspPlot we still printed and saved all the plotly information in analyses.json in a jasp file. This could get quite big and was just duplicate because it's the exact same information as in the actual json files.
In a nutshell:
loadPlotlyJsonInResultsand everything around it.jsloads the plotly json file directly.ColumnEncoder::decodeJson(plotlyJson);in analysis.cpp, we now do this in R right before writing the json file usingwriteLines(.plotlyToJson(plotlyOrTryError), plotlyJsonFile). We don't exposedecodeJsonso this first decodes the R object and then make it into json.Obviously made with 🤖 .